Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get dependencies up to latest versions possible #71

Open
juanpaco opened this issue Aug 19, 2015 · 5 comments
Open

Get dependencies up to latest versions possible #71

juanpaco opened this issue Aug 19, 2015 · 5 comments
Assignees

Comments

@juanpaco
Copy link
Contributor

Investigate feasibility of Python 3 as well.

@juanpaco juanpaco self-assigned this Aug 19, 2015
@cojoco
Copy link

cojoco commented Aug 25, 2015

As far as investigating feasibility of Python 3 goes, I have a copy of the dev branch Topical Guide that I just spent a few hours making "work" with Python 3. It throws some kind of database error when I run the script to import the 'State of the Union' dataset, but I ran the topical guide and the dataset was there. The server appeared to be doing what it needed to. There are probably better ways to do it than what I did (I just looked for things that worked via Google), but it seems to work.

I used a Python 3 virtual environment (by running 'pyvenv venv' in my Topical Guide directory), and was able to install everything from the 'requirements.txt' file fine. I think I needed to 'pip install python-dateutil' as well, I'm not sure why I need to do that on my machine.

You can see my attempt at making the Topical Guide Python3 compatible here: https://github.com/cojoco/topicalguide/tree/python3Test

@cojoco
Copy link

cojoco commented Aug 26, 2015

I tried installing from that branch I posted above, and there are definitely still some problems with it (like it not having the data it should). It is likely related to the database error I was getting when attempting to run the analysis on the dataset: 'django.db.utils.IntegrityError: NOT NULL constraint failed: visualize_documentanalysismetricvalue.document_id'.

@cojoco
Copy link

cojoco commented Aug 26, 2015

Turns out when I ran '2to3', it didn't actually write the changes. I ran it with the -w option, and it wrote its changes, and now the database error has disappeared. There do still appear to be some problems, however (such as the Topics Over Time visualization not working, and nothing being listed when you click "Topic" then select "All Topics").

@cojoco
Copy link

cojoco commented Aug 31, 2015

I tried getting the master branch to be compatible with Python 3, since it seems to work better in general on my machine. It seems to work perfectly well to me, though the topics are different from what's on tg.byu.edu. My work at getting the master branch compatible is here: https://github.com/cojoco/topicalguide/tree/python3Master.

@juanpaco
Copy link
Contributor Author

juanpaco commented Sep 3, 2015

Master is quite a ways behind dev. I think it's missing the entire metadata map, for example. :(

I had concurrently started this upgrade process after the meeting when we first talked about it. I'll continue working on my branch for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants