Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebXRHand doesn't efficiently obtain hand poses #10454

Closed
rgerd opened this issue Jun 3, 2021 · 2 comments · Fixed by #10481
Closed

WebXRHand doesn't efficiently obtain hand poses #10454

rgerd opened this issue Jun 3, 2021 · 2 comments · Fixed by #10481
Assignees
Labels
Milestone

Comments

@rgerd
Copy link
Member

rgerd commented Jun 3, 2021

The WebXR hand tracking API explainer recommends using fillPoses and fillJointRadii as a way of reducing the number of javascript objects created per-frame while updating tracked hand models:
https://github.com/immersive-web/webxr-hand-input/blob/main/explainer.md#efficiently-obtaining-hand-poses

WebXRHand still uses the inefficient method:

let pose = xrFrame.getJointPose!(xrJoint, referenceSpace);

In order for BabylonNative to maintain support, we will want to get BabylonJS/BabylonNative#773 closed first.

@RaananW
Copy link
Member

RaananW commented Jun 7, 2021

Hi @rgerd - will you be implementing this? Should I assign you?

@rgerd
Copy link
Member Author

rgerd commented Jun 8, 2021

@RaananW Yes I'm working on it now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants