Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an include option for basicAuth #219

Closed
Applelo opened this issue Sep 27, 2023 · 3 comments · Fixed by #212
Closed

Add an include option for basicAuth #219

Applelo opened this issue Sep 27, 2023 · 3 comments · Fixed by #212
Labels
enhancement New feature or request
Milestone

Comments

@Applelo
Copy link

Applelo commented Sep 27, 2023

Is your feature request related to a problem? Please describe.

Currently, the basicAuth option accept only exclude routes options but I need to protect one API route with basic authentification (for webhook purpose).

Describe the solution you'd like

Add an include option for basicAuth to set the route I want to protect.

Describe alternatives you've considered

Maybe access to basicAuthoption inside routeRules option can be a proper alternative ?

@Applelo Applelo added the enhancement New feature or request label Sep 27, 2023
@Baroshem
Copy link
Owner

In my personal opinion, the better approach would be to go with include option (as currently basic auth configuration is passed to private runtime config due to storing credentials).

@danielroe
Which option do you think would be better? Route Rules or maybe the include in the module configuration? (also right now, we support exclude option).

@Baroshem Baroshem added this to the 1.0.0 milestone Sep 27, 2023
@Baroshem
Copy link
Owner

Added in 40c6a72

Will be added in upcoming 1.0.0-rc.1 version :)

@Baroshem Baroshem mentioned this issue Sep 28, 2023
3 tasks
@Applelo
Copy link
Author

Applelo commented Sep 28, 2023

Nice job 🔥 I will use it for sure when it will be shipped. Thanks for your reactivity :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants