Redirect happening before login is finished processing #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug in which redirect to dashboardRoute was happening too fast (before loginWithPassword() was finished processing) resulting in the Router evaluating dashboardRoute while Meteor.user() is still null. Now we redirect to dashboardRoute only after login is finished processing.
|
Hmm, what kind of stuff comes back from the error handling? |
|
My worry with this PR is the errors will be in English while our package support internationalization... |
…when we call Accounts.createUser since that’s where errors are most likely to happen. Error from Meteor.loginWithPassword is very unlikely since we’re logging them in with the account they just created.
|
Good catch RE i18n :) I just updated the PR to fix that. Note that I put placeholder entries into german.coffee and spanish.coffee since I'm not fluent in either of those languages. |
…e strings with “.” so that if they are chained together in the UI (multiple errors at the same time), the punctuation will be correct.
queso
added a commit
that referenced
this pull request
Feb 11, 2014
Redirect happening before login is finished processing
|
Merging, thx for the help! We will clean up the translations in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug in which redirect to dashboardRoute was happening too fast (before loginWithPassword() was finished processing) resulting in the Router evaluating dashboardRoute while Meteor.user() is still null.
Now we redirect to dashboardRoute only after login is finished processing.