-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 13 upgrade #321
Angular 13 upgrade #321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good...thanks for tackling this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most are just comments.
I think I still need to pull the changes and run storybook to poke around the components, especially the ones with diffs?
I saw the "revert lockfile v2 change" commit. Were there problems, or are we waiting to pull that lever for later?
Any other gotchas or concessions to make with this PR? Did you get Storybook working again or are we planning to bail on it, put a pin in it...?
@hitjim Yeah, storybook is still busted. I'm going to try and get it running for the rest of the day today and if I can't then I'll just accept it's broken for now and fix it later or maybe scrap it. The lockfile was my fault from playing around with nvm too much during the upgrade process 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
## [5.0.0](v4.4.6...v5.0.0) (2022-04-20) ### ⚠ BREAKING CHANGES * Upgrade Angular from 11 to 13 Co-authored-by: Marc Celestini <mcelestini@bellese.io> ### Features * Angular 13 Upgrade ([#321](#321)) ([39669af](39669af))
🎉 This PR is included in version 5.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.