Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular 13 upgrade #321

Merged
merged 9 commits into from
Apr 20, 2022
Merged

Angular 13 upgrade #321

merged 9 commits into from
Apr 20, 2022

Conversation

mcelestini
Copy link
Collaborator

No description provided.

@mcelestini mcelestini self-assigned this Apr 18, 2022
dianadean
dianadean previously approved these changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@dianadean dianadean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good...thanks for tackling this!

src/app/modules/file-upload/file-upload.component.ts Outdated Show resolved Hide resolved
hitjim
hitjim reviewed Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@hitjim hitjim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most are just comments.

I think I still need to pull the changes and run storybook to poke around the components, especially the ones with diffs?

I saw the "revert lockfile v2 change" commit. Were there problems, or are we waiting to pull that lever for later?

Any other gotchas or concessions to make with this PR? Did you get Storybook working again or are we planning to bail on it, put a pin in it...?

angular.json Show resolved Hide resolved
public_api.ts Show resolved Hide resolved
src/app/modules/bar-graph/bar-graph.component.ts Show resolved Hide resolved
src/app/modules/file-upload/file-upload.component.ts Show resolved Hide resolved
@mcelestini
Copy link
Collaborator Author

@hitjim Yeah, storybook is still busted. I'm going to try and get it running for the rest of the day today and if I can't then I'll just accept it's broken for now and fix it later or maybe scrap it. The lockfile was my fault from playing around with nvm too much during the upgrade process 😄

dianadean
dianadean previously approved these changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@dianadean dianadean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcelestini mcelestini merged commit 39669af into main Apr 20, 2022
@mcelestini mcelestini deleted the angular-13-upgrade branch April 20, 2022 19:39
cshamrick pushed a commit that referenced this pull request Apr 20, 2022
@semantic-release-bot
chore(release): 5.0.0 [skip ci]
f7b72cf 
## [5.0.0](v4.4.6...v5.0.0) (2022-04-20)

### ⚠ BREAKING CHANGES

* Upgrade Angular from 11 to 13

Co-authored-by: Marc Celestini <mcelestini@bellese.io>

### Features

* Angular 13 Upgrade ([#321](#321)) ([39669af](39669af))
@cshamrick
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hitjim hitjim hitjim left review comments

@CharlesSchaack CharlesSchaack CharlesSchaack approved these changes

@dianadean dianadean dianadean approved these changes

@cshamrick cshamrick Awaiting requested review from cshamrick

Assignees

@mcelestini mcelestini

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mcelestini @cshamrick @hitjim @CharlesSchaack @dianadean