Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the new custom titlebar #232

Closed
guledali opened this issue Jun 19, 2018 · 6 comments
Closed

Support the new custom titlebar #232

guledali opened this issue Jun 19, 2018 · 6 comments

Comments

@guledali
Copy link

guledali commented Jun 19, 2018

vscode just released a custom titlebar see microsoft/vscode#39972
Its right now on insiders @Binaryify I hope this theme will take full advantages of this feature, maybe give us Yosemite icons (titlebar) on windows that will look really good with one dark theme

screenshot 50

@Binaryify
Copy link
Owner

Binaryify commented Jun 19, 2018

it do support, just need set "window.titleBarStyle": "custom"
image

but if people need some icon, they can install different icon theme

@guledali
Copy link
Author

Could you add yosemite icons to your theme like this

40278352-1265254c-5c30-11e8-83fc-835064b10f0e

@Binaryify
Copy link
Owner

no, people should can choose the icon theme what they want, but no bind the icon theme in this theme
image

@guledali
Copy link
Author

guledali commented Jun 20, 2018

@no those are file icon theme, no what I meant are the icons on the titlebar
green-maximize-zoom-button-os-x-yosemite

If you could make a custom titlebar that allow yosemite icons instead windows icons which now possible thanks to "window.titleBarStyle": "custom" and it will suit your theme better, just a personal taste

@Binaryify
Copy link
Owner

seem like can't change it now

@guledali
Copy link
Author

Okay thanks anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants