frontend/backend: show outputs as individual row for receive transactions #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This can be tested by checking out #2844 ./scripts/regtest/run_regtest.sh
make servewallet-regtest
make webdev
cd ./scrips/regtest/
export DOCKER_REGTEST=1
source examples.sh
mine_blocks 101
example_bitbox_receive_many |
NicolaLS
force-pushed
the
distinct-outputs-receive-only
branch
from
79a11e6 to
879b139
Compare
The transactions/transaction endpoint actually return "send", "receive" and "send_to_self" but the ITransaction type was "self" this was unnoticed because the type was never directly checked. But it should be the correct type, also in preparation for the frontend collaborative type implementation.
Remove the "first" class that was used in combination with "container" its CSS rule does not contain any CSS declarations and thus does not do anything. The CSS rule was empty after this commit: 5e1898b Since the index prop on the transaction component is only used to add this class it can also be removed.
Return tx. output(s) data for recevie transactions containing the address, amount, amountAtTime, and note per output. Non utxo model transactions will also contain one value in this list which will have the same values as the tx. level address, amount, etc.. This can be used to represent individual outputs as transactions for transactions that are of type receive.
Use the outputs data to display one transction per output item for recevie transactions. This also enables the user to create a note for each output address of a recevie tx.
NicolaLS
force-pushed
the
distinct-outputs-receive-only
branch
from
879b139 to
d173ad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1728
Display each output of a receive transaction as one transaction in the app. The outputs data is only added to the endpoint response if the transaction is of type receive. Non-utxo model transactions e.g. ETH will just contain a single item in the
outputsfield which is weird but fine imo.In the current implementation the index used for the note key (
txid:idx) is set/defined by the order of theAdressesin theTransactionDatastruct returned bytxInfo(here)outputsfield right now kind of implies that we are dealing with the actualoutpoint/output index of the transaction which is not true and could be confusing when working on the code after some time.Probably it would be better to add
indextoTransactionOutputand actually set it to the transactions output index and then use that in the frontend. Let me know if you think the current implementation is fine or if I should change that.