Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSPS0 typo nit: JSON does not support numbers with leading 0s #106

Open
ZmnSCPxj-jr opened this issue Apr 3, 2024 · 1 comment
Open

LSPS0 typo nit: JSON does not support numbers with leading 0s #106

ZmnSCPxj-jr opened this issue Apr 3, 2024 · 1 comment

Comments

@ZmnSCPxj-jr
Copy link
Contributor

https://nullprogram.com/blog/2019/12/28/

LSPS0 Common Schemas describes "Client rejected" as 001 https://github.com/BitcoinAndLightningLayerSpecs/lsp/blob/main/LSPS0/common-schemas.md#001-client-rejected however JSON does not support numbers with leading 0s. I suggest rewriting it as 1 instead to prevent misleading implementations into actually writing an actual 001 in the actual JSON.
@SeverinAlexB
Copy link
Collaborator

Ack. I think this reasoning is stronger than "error codes should always have at least 3 digits for it to be recognizable".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SeverinAlexB @ZmnSCPxj-jr