-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
broken fastify-kafka implementation when using rdkafka bigger than 2.14.0 #1016
Comments
I could confirm with |
Thanks for reporting this. I have not seen this behavior myself since my service calls I made a fix in #1017. Would one of you be able to try that change out and verify it fixes the issue? |
Thanks a lot for the quick fix. :) I could verify that our integration tests terminate when using version 2.16.1 build from branch 'user/garywilb/consume_loop_disconnect', while the process keeps running with version 2.15.0. We shut down our consumer and producers by publishing a shutdown event: process.on('shutdown', () => {
if (consumer.isConnected()) {
logger.info('Disconnecting from cluster...');
consumer.disconnect(handleKafkaError);
}
});
consumer.on('disconnected', () => {
logger.info('Disconnected from cluster');
}); No |
Thank you for the fast fix ;). |
See
fastify/fastify-kafka#99
We had to revert to version 2.14.0 to ensure everything works properly. I assume it is because of #982 by @GaryWilber (no blame on him). It seems that the connection is not disconnected properly and so the test runner hangs.
The text was updated successfully, but these errors were encountered: