Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ OPT: Increase accuracy of Complex functions #27

Open
0xpanicError opened this issue Mar 18, 2024 · 1 comment
Open

⚙️ OPT: Increase accuracy of Complex functions #27

0xpanicError opened this issue Mar 18, 2024 · 1 comment

Comments

@0xpanicError
Copy link
Member

⚙️ [OPTIMIZATION]

Description:
Some tests in Complex.t.sol have low accuracy (upto none or one decimal place). Improve the accuracy to at least 3 decimal places (for now, ideally should be around 7-8 decimal places).

Objective:
Optimise library and rewrite the following tests such that they have 3 decimal places of accuracy.

function testDivZ() public {}         // dont divide output by scale
function testCalcR() public {}        // dont divide output by scale
function testToPolar() public {}      // dont divide output by scale
function testPowZ() public {}         // have 3 decimals of accuracy instead of one

Source:
./test/Complex.t.sol

@Oyase-shinobi
Copy link

Hello team
I am a passionate and skilled blockchain and web3 frontend developer
I would love to engage in your team and contribute in this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants