Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/f top bug #55

Closed
iZeaoGamer opened this issue Sep 15, 2018 · 4 comments
Closed

/f top bug #55

iZeaoGamer opened this issue Sep 15, 2018 · 4 comments

Comments

@iZeaoGamer
Copy link
Contributor

iZeaoGamer commented Sep 15, 2018 •
edited
Loading

Hey, I have a couple of bugs I wanted to discuss with you.

  1. When you use /f top, it'll display an error, causing this such error:
    /f top
15.09 14:27:03 [Server] Server thread/CRITICAL Unhandled exception executing command 'f top' in faction: Argument 2 passed to factions\utils\Pager::__construct() must be of the type integer, string given, called in /plugins/FactionsPE-patch-2/src/factions/command/Top.php on line 71
15.09 14:27:03 [Server] Server thread/CRITICAL TypeError: "Argument 2 passed to factions\utils\Pager::__construct() must be of the type integer, string given, called in /plugins/FactionsPE-patch-2/src/factions/command/Top.php on line 71" (EXCEPTION) in "FactionsPE-patch-2/src/factions/utils/Pager" at line 32
15.09 14:27:03 [Server] Server thread/DEBUG #0 FactionsPE-patch-2/src/factions/command/Top(71): factions\utils\Pager->__construct(string top-header, string power, integer 5, array Array(), pocketmine\Player object, Closure object)
15.09 14:27:03 [Server] Server thread/DEBUG #1 FactionsPE-patch-2/src/dominate/Command(509): factions\command\Top->perform(pocketmine\Player object, string f, array Array())
15.09 14:27:03 [Server] Server thread/DEBUG #2 FactionsPE-patch-2/src/dominate/Command(480): dominate\Command->execute(pocketmine\Player object, string f, array Array())
15.09 14:27:03 [Server] Server thread/DEBUG #3 src/pocketmine/command/SimpleCommandMap(258): dominate\Command->execute(pocketmine\Player object, string f, array Array())
15.09 14:27:03 [Server] Server thread/DEBUG #4 src/pocketmine/Server(1955): pocketmine\command\SimpleCommandMap->dispatch(pocketmine\Player object, string f top)
15.09 14:27:03 [Server] Server thread/DEBUG #5 src/pocketmine/Player(2191): pocketmine\Server->dispatchCommand(pocketmine\Player object, string f top)
15.09 14:27:03 [Server] Server thread/DEBUG #6 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(113): pocketmine\Player->chat(string ./f top)
15.09 14:27:03 [Server] Server thread/DEBUG #7 src/pocketmine/network/mcpe/protocol/TextPacket(128): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleText(pocketmine\network\mcpe\protocol\TextPacket object)
15.09 14:27:03 [Server] Server thread/DEBUG #8 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(92): pocketmine\network\mcpe\protocol\TextPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
15.09 14:27:03 [Server] Server thread/DEBUG #9 src/pocketmine/network/mcpe/protocol/BatchPacket(114): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\TextPacket object)
15.09 14:27:03 [Server] Server thread/DEBUG #10 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(92): pocketmine\network\mcpe\protocol\BatchPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
15.09 14:27:03 [Server] Server thread/DEBUG #11 src/pocketmine/Player(3056): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
15.09 14:27:03 [Server] Server thread/DEBUG #12 src/pocketmine/network/mcpe/RakLibInterface(162): pocketmine\Player->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
15.09 14:27:03 [Server] Server thread/DEBUG #13 vendor/pocketmine/raklib/src/server/ServerHandler(98): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string 82.38.148.87 56021, raklib\protocol\EncapsulatedPacket object, integer 0)
15.09 14:27:03 [Server] Server thread/DEBUG #14 src/pocketmine/network/mcpe/RakLibInterface(103): raklib\server\ServerHandler->handlePacket()
15.09 14:27:03 [Server] Server thread/DEBUG #15 src/pocketmine/network/Network(94): pocketmine\network\mcpe\RakLibInterface->process()
15.09 14:27:03 [Server] Server thread/DEBUG #16 src/pocketmine/network/mcpe/RakLibInterface(80): pocketmine\network\Network->processInterface(pocketmine\network\mcpe\RakLibInterface object)
15.09 14:27:03 [Server] Server thread/DEBUG #17 vendor/pocketmine/snooze/src/SleeperHandler(120): pocketmine\network\mcpe\RakLibInterface->pocketmine\network\mcpe\{closure}()
15.09 14:27:03 [Server] Server thread/DEBUG #18 vendor/pocketmine/snooze/src/SleeperHandler(82): pocketmine\snooze\SleeperHandler->processNotifications()
15.09 14:27:03 [Server] Server thread/DEBUG #19 src/pocketmine/Server(2259): pocketmine\snooze\SleeperHandler->sleepUntil(double 1537021623.2798)
15.09 14:27:03 [Server] Server thread/DEBUG #20 src/pocketmine/Server(2134): pocketmine\Server->tickProcessor()
15.09 14:27:03 [Server] Server thread/DEBUG #21 src/pocketmine/Server(1700): pocketmine\Server->start()
15.09 14:27:03 [Server] Server thread/DEBUG #22 src/pocketmine/PocketMine(243): pocketmine\Server->__construct(BaseClassLoader object, pocketmine\utils\MainLogger object, string /, string /plugins/)
15.09 14:27:03 [Server] Server thread/DEBUG #23 /custom-php7.2.phar(1): require(string phar:///custom-php7.2.phar/src/pocketmine/PocketMine.php)

I've tried with a phar also, and it seems to appear with the same error.
2. When you do /f top online, it would say "No Factions have been created" although, they were created.
3. When you use /f perm list, this error displays:

Unhandled exception executing command 'f perm list' in faction: Call to undefined method factions\utils\Pager::getHeader()
15.09 14:28:51 [Server] Server thread/CRITICAL Error: "Call to undefined method factions\utils\Pager::getHeader()" (EXCEPTION) in "FactionsPE-patch-2/src/factions/command/PermList" at line 63
15.09 14:28:51 [Server] Server thread/DEBUG #0 FactionsPE-patch-2/src/dominate/Command(509): factions\command\PermList->perform(pocketmine\Player object, string f, array Array())
15.09 14:28:51 [Server] Server thread/DEBUG #1 FactionsPE-patch-2/src/dominate/Command(480): dominate\Command->execute(pocketmine\Player object, string f, array Array())
15.09 14:28:51 [Server] Server thread/DEBUG #2 FactionsPE-patch-2/src/dominate/Command(480): dominate\Command->execute(pocketmine\Player object, string f, array Array())
15.09 14:28:51 [Server] Server thread/DEBUG #3 src/pocketmine/command/SimpleCommandMap(258): dominate\Command->execute(pocketmine\Player object, string f, array Array())
15.09 14:28:51 [Server] Server thread/DEBUG #4 src/pocketmine/Server(1955): pocketmine\command\SimpleCommandMap->dispatch(pocketmine\Player object, string f perm list)
15.09 14:28:51 [Server] Server thread/DEBUG #5 src/pocketmine/Player(2191): pocketmine\Server->dispatchCommand(pocketmine\Player object, string f perm list)
15.09 14:28:51 [Server] Server thread/DEBUG #6 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(113): pocketmine\Player->chat(string ./f perm list)
15.09 14:28:51 [Server] Server thread/DEBUG #7 src/pocketmine/network/mcpe/protocol/TextPacket(128): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleText(pocketmine\network\mcpe\protocol\TextPacket object)
15.09 14:28:51 [Server] Server thread/DEBUG #8 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(92): pocketmine\network\mcpe\protocol\TextPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
15.09 14:28:51 [Server] Server thread/DEBUG #9 src/pocketmine/network/mcpe/protocol/BatchPacket(114): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\TextPacket object)
15.09 14:28:51 [Server] Server thread/DEBUG #10 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(92): pocketmine\network\mcpe\protocol\BatchPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
15.09 14:28:51 [Server] Server thread/DEBUG #11 src/pocketmine/Player(3056): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
15.09 14:28:51 [Server] Server thread/DEBUG #12 src/pocketmine/network/mcpe/RakLibInterface(162): pocketmine\Player->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
15.09 14:28:51 [Server] Server thread/DEBUG #13 vendor/pocketmine/raklib/src/server/ServerHandler(98): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string 82.38.148.87 56021, raklib\protocol\EncapsulatedPacket object, integer 0)
15.09 14:28:51 [Server] Server thread/DEBUG #14 src/pocketmine/network/mcpe/RakLibInterface(103): raklib\server\ServerHandler->handlePacket()
15.09 14:28:51 [Server] Server thread/DEBUG #15 src/pocketmine/network/Network(94): pocketmine\network\mcpe\RakLibInterface->process()
15.09 14:28:51 [Server] Server thread/DEBUG #16 src/pocketmine/network/mcpe/RakLibInterface(80): pocketmine\network\Network->processInterface(pocketmine\network\mcpe\RakLibInterface object)
15.09 14:28:51 [Server] Server thread/DEBUG #17 vendor/pocketmine/snooze/src/SleeperHandler(120): pocketmine\network\mcpe\RakLibInterface->pocketmine\network\mcpe\{closure}()
15.09 14:28:51 [Server] Server thread/DEBUG #18 vendor/pocketmine/snooze/src/SleeperHandler(82): pocketmine\snooze\SleeperHandler->processNotifications()
15.09 14:28:51 [Server] Server thread/DEBUG #19 src/pocketmine/Server(2259): pocketmine\snooze\SleeperHandler->sleepUntil(double 1537021731.9797)
15.09 14:28:51 [Server] Server thread/DEBUG #20 src/pocketmine/Server(2134): pocketmine\Server->tickProcessor()
15.09 14:28:51 [Server] Server thread/DEBUG #21 src/pocketmine/Server(1700): pocketmine\Server->start()
15.09 14:28:51 [Server] Server thread/DEBUG #22 src/pocketmine/PocketMine(243): pocketmine\Server->__construct(BaseClassLoader object, pocketmine\utils\MainLogger object, string /, string /plugins/)
15.09 14:28:51 [Server] Server thread/DEBUG #23 /custom-php7.2.phar(1): require(string phar:///custom-php7.2.phar/src/pocketmine/PocketMine.php)

I hope you can fix these bugs.
Thanks.
@Kris-Driv
Copy link
Contributor

Yeah, I'll fix this asap. First issue occurs because I added /f top online and now I sort the list wrongly in the code and that creates this error. And the second error is because I added $pager->sendTitle() instead of sending the list header manually as I've done so far. In short: I changed the API but didn't make changes to places where I used to use it.

@iZeaoGamer
Copy link
Contributor Author

Okay, thanks. Let me know when this get's fixed. Cheers.

@DaWOLFEE
Copy link

DaWOLFEE commented Jan 3, 2019

Gives me a Internal Server Error when I do this.

@Kris-Driv
Copy link
Contributor

This can no longer be replicated. So I would assume that it's fixed at some point. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iZeaoGamer @Kris-Driv @DaWOLFEE