Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CHECK on blinding factor from generator/main_impl.h #49

Closed
apoelstra opened this issue Mar 27, 2019 · 1 comment
Closed

Remove CHECK on blinding factor from generator/main_impl.h #49

apoelstra opened this issue Mar 27, 2019 · 1 comment

Comments

@apoelstra
Copy link
Contributor

See ElementsProject/elements#540
@instagibbs
Copy link
Contributor

Quick scan of all other secp API usage seems to not be asserting in any case. For example, secp256k1_pedersen_commit simply wipes results and returns 0 if overflow is encountered on blinding factor.

@apoelstra apoelstra mentioned this issue Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apoelstra @instagibbs