New parameters in SimulationConfig #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
WeinaJi
commented
Apr 6, 2022
WeinaJi
commented
- Parse floating point with type "double" to align with parser "nlohmann::json"
- Parse variables in "manifest" section and apply them to the configuration file
- Parse "network" parameter for the path of circuit_config file
mgeplf
reviewed
Apr 6, 2022
WeinaJi
force-pushed
the
weji/simconf_manifest
branch
from
6606b49 to
ce686c6
Compare
WeinaJi
commented
Apr 6, 2022
- Parse floating point with type "double" to align with parser "nlohmann::json" - Parse variables in "manifest" section and apply them to the configuration file - Parse "network" parameter for the path of circuit_config file
- unify the parsing function for manifest
- add one unittest for manifest and network
WeinaJi
force-pushed
the
weji/simconf_manifest
branch
from
ce686c6 to
70feb1c
Compare
|
Looks reasonable to me, if @NadirRoGue is good, we'll merge it. |
|
Looks good to me as well, thanks! |
|
Thanks, @mgeplf @NadirRoGue . Can you merge this PR ? I don't have the permission. |
|
Done, thanks. I will make a release in a bit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.