Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make package ready and upload on PyPI #12

Open
FrancescoCasalegno opened this issue Apr 12, 2022 · 2 comments
Open

Make package ready and upload on PyPI #12

FrancescoCasalegno opened this issue Apr 12, 2022 · 2 comments
Labels
✅ Open Source QA Quality Assurance for Blue Brain Open Sourcing
Milestone

Comments

@FrancescoCasalegno
Copy link
Contributor

FrancescoCasalegno commented Apr 12, 2022

This could be complicated by the fact that the installation of PyTorch-Geometric is not as trivial as pip install torch-geometric.

This is particularly true for the torch-scatter, torch-sparse, ... dependencies of torch-geometric. For these packages, it seems like wheels are not on PyPI but must be found instead on https://data.pyg.org/whl/torch-${TORCH}+${CUDA}.html.

Notice that we do need such dependencies for our project:

morphoclass/install.sh

Lines 54 to 57 in 72f59fa

pip install torch-scatter --no-index -f "$FIND_LINKS"
pip install torch-sparse --no-index -f "$FIND_LINKS"
pip install torch-cluster --no-index -f "$FIND_LINKS"
pip install torch-spline-conv --no-index -f "$FIND_LINKS"

@Stannislav Stannislav added this to the Open-Source milestone Apr 14, 2022
@FrancescoCasalegno FrancescoCasalegno added the ✅ Open Source QA Quality Assurance for Blue Brain Open Sourcing label Apr 19, 2022
@FrancescoCasalegno
Copy link
Contributor Author

Update

PyPI seems to have PyTorch-Geometric and its various torch-scatter ... dependencies:

So:

  • Do they work?
  • If Yes, then why does PyTorch-Geometric tells you to install its dependcies like torch-scatter with -f https://data.pyg.org/whl/torch-${TORCH}+${CUDA}.html instead?
  • Maybe everything works fine on CPU doing pip install ... from PyPI, but it breaks for GPUs?
  • If Yes, then maybe we can have our package on PyPI for CPU only, and then rely on our install.sh for GPU install and usage.

@FrancescoCasalegno
Copy link
Contributor Author

FrancescoCasalegno commented Apr 19, 2022

Update

It turns out that torch-scatter, etc. are indeed on PyPI. But only the source tarball is there, so pip install torch-scatter will take some time to compile the C extensions!

On the other hand, torch-geometric is quick to install with pip install torch-geometric even if only the source tarball is on PyPI because torch-geometric is a pure-Python package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Open Source QA Quality Assurance for Blue Brain Open Sourcing
Projects
None yet
Development

No branches or pull requests

2 participants