Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pynrrd1.0 #37

Closed
arnaudon opened this issue Nov 7, 2024 · 3 comments
Closed

pynrrd1.0 #37

arnaudon opened this issue Nov 7, 2024 · 3 comments

Comments

@arnaudon
Copy link
Contributor

arnaudon commented Nov 7, 2024

with pynrrd1.1.1, its not needed to prepend None in https://github.com/BlueBrain/voxcell/blob/main/voxcell/voxel_data.py#L143

in fact, it results in a crash, so maybe we need to upper bound pynrrd in setup.py to <1?

@mgeplf
Copy link
Collaborator

mgeplf commented Nov 7, 2024

We'll want this new version, as it removes the nptyping requirements.

However, yes, we need to fix this first.
If we don't prepend none, is the behavior correct?
Also, are the space dimensions being set right with the new version on read?
I don't think we want to change our API, so we'll need to work around that if they are different.

@arnaudon
Copy link
Contributor Author

arnaudon commented Nov 7, 2024

I didn't check, I just remove the none, and my test in region-grower didn't crash. I can try a better fix if you want.

@mgeplf
Copy link
Collaborator

mgeplf commented Nov 21, 2024

fixed in #38

@mgeplf mgeplf closed this as completed Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants