Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDEA] Allow specifying map when first accessing the webapp by just providing map name #589

Closed
KW46 opened this issue Aug 7, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@KW46
Copy link

KW46 commented Aug 7, 2024

Right now,the webapp by default loads the first available map.
It apparently first checks if URL hash is valid: https://github.com/BlueMap-Minecraft/BlueMap/blob/master/BlueMapCommon/webapp/src/js/BlueMapApp.js#L169 - If not, load first available map.

Now in my setup I have a static map (Skellige from TW3). At the time of writing, the only available map.
Soon there will be one or two other maps (live maps) and this map would no longer be loaded as default map (one of the live maps will be).
Now this Skellige map is used as a preview for this map; if someone would try to visit https://bluemap.kwarde.com/#skellige (URL provided), they would still see the live map and would have to manually select a map. (Either that or the person that added that URL to map description would have to provide a different URL, of course).
This currently is not possible because it requires the full valid url hash: https://github.com/BlueMap-Minecraft/BlueMap/blob/master/BlueMapCommon/webapp/src/js/BlueMapApp.js#L713

Cba to create a PR myself at the moment, if there's agreement on this idea (at first sight it seems like an easy update - though I barely know how this webapp works so I've no ideas what consequences of that could be, haven't looked into the code that much yet -- ofc the non provides values will have to be defined at this point, but apart from that no idea).
Thought it'd be a slight quality of life feature.

@TBlueF TBlueF added the bug Something isn't working label Aug 8, 2024
@github-project-automation github-project-automation bot moved this to Planned (unordered) in TODO / Idea board Aug 8, 2024
@TBlueF
Copy link
Member

TBlueF commented Aug 8, 2024

Actually it's more a bug that this doesn't work rn .. it used to work like this ^^
I'll make sure to fix it for next version.

@TBlueF TBlueF closed this as completed in 074bbc3 Sep 15, 2024
@github-project-automation github-project-automation bot moved this from In progress to Ready for next release in TODO / Idea board Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants