Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speed up readers in the unmarshall path #253

Merged
merged 2 commits into from
Sep 13, 2023
Merged

feat: speed up readers in the unmarshall path #253

merged 2 commits into from
Sep 13, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 13, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: -0.04% ⚠️

Comparison is base (0b6ba93) 83.32% compared to head (2936d2e) 83.29%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   83.32%   83.29%   -0.04%     
==========================================
  Files          28       28              
  Lines        3269     3269              
  Branches      678      678              
==========================================
- Hits         2724     2723       -1     
  Misses        330      330              
- Partials      215      216       +1     
Files Changed Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/_private/unmarshaller.py 94.97% <100.00%> (+0.23%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Sep 13, 2023

CI seems happy. cython had a lot of bugs with cdef void before but they all appear to be fixed 🤞

@bdraco bdraco marked this pull request as ready for review September 13, 2023 18:21
@bdraco bdraco merged commit f9b61b8 into main Sep 13, 2023
@bdraco bdraco deleted the readers branch September 13, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant