Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speed up unmarshalling Variants #254

Merged
merged 1 commit into from
Sep 20, 2023
Merged

feat: speed up unmarshalling Variants #254

merged 1 commit into from
Sep 20, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 20, 2023

This is a 3.5% speed up, but we can apply the same idea in a few more places

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.46% ⚠️

Comparison is base (f9b61b8) 83.29% compared to head (5a48d02) 82.83%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   83.29%   82.83%   -0.46%     
==========================================
  Files          28       28              
  Lines        3269     3275       +6     
  Branches      678      678              
==========================================
- Hits         2723     2713      -10     
- Misses        330      338       +8     
- Partials      216      224       +8     
Files Changed Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/_private/unmarshaller.py 89.62% <35.29%> (-5.36%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Sep 20, 2023

production testing looks good

@bdraco bdraco marked this pull request as ready for review September 20, 2023 08:27
@bdraco bdraco merged commit dd74a84 into main Sep 20, 2023
17 of 19 checks passed
@bdraco bdraco deleted the token branch September 20, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant