Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve writer performance with a deque #30

Merged
merged 3 commits into from
Sep 24, 2022
Merged

feat: improve writer performance with a deque #30

merged 3 commits into from
Sep 24, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 24, 2022

  • The only calls are get_nowait, put_nowait, and empty which means deque is a better fit since we don't need thread safety here

- The only calls are get_nowait, put_nowait, and empty which means
  SimpleQueue is a better fit
@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Base: 80.83% // Head: 80.83% // No change to project coverage 👍

Coverage data is based on head (f9f9757) compared to base (016e71e).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #30   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files          24       24           
  Lines        2849     2849           
  Branches      623      623           
=======================================
  Hits         2303     2303           
  Misses        333      333           
  Partials      213      213           
Impacted Files Coverage Δ
src/dbus_fast/__version__.py 0.00% <0.00%> (ø)
src/dbus_fast/aio/message_bus.py 87.21% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bdraco bdraco closed this Sep 24, 2022
@bdraco bdraco reopened this Sep 24, 2022
@bdraco
Copy link
Member Author

bdraco commented Sep 24, 2022

Actually collections.deque might make more sense

@bdraco bdraco changed the title feat: improve writer performance with SimpleQueue feat: improve writer performance with a deque Sep 24, 2022
@bdraco bdraco marked this pull request as ready for review September 24, 2022 16:56
@bdraco bdraco merged commit 09af56e into main Sep 24, 2022
@bdraco bdraco deleted the simple_queue branch September 24, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant