feat: add withdraw Discord command #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peartobear
approved these changes
Sep 2, 2019
armurbalda
approved these changes
Sep 2, 2019
There was a problem hiding this comment.
Concept ACK.
With this new one we have 9 Discord commands now and I think I should improve the help command so that it actually shows how to use the commands instead of just listing them.
Listing the full command with all options in withdraw <OTP token> <currency> <address> <amount in whole coins *or* "all"> style would definitely help.
|
I created an issue for the improved help command: #147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #137
This PR add a
withdrawcommand to the Discord bot. That command is secured by OTP and can be used like this:withdraw <OTP token> <currency> <invoice>: to withdraw lightning fundswithdraw <OTP token> <currency> <address> <amount in whole coins *or* "all">: to withdraw onchain coinsWith this new one we have 9 Discord commands now and I think I should improve the
helpcommand so that it actually shows how to use the commands instead of just listing them.