Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for autofill/autocomplete to be switched for supporting components #1007

Open
ghost opened this issue Dec 5, 2016 · 1 comment
Open
Assignees

Comments

@ghost
Copy link

ghost commented Dec 5, 2016

Components which produce form elements which support the autocomplete attribute should allow this attribute to be set/unset. The default is to not set the autocomplete attribute.

note: @jonathanaustin

As a bare minimum we should allow autocomplete to be turned off by having a boolean isAutoComplete() where the default is true. This is the worst option.

If we want to do this properly then the autocomplete attribute should allow for autofill detail tokens and not just on/off. One step up from the bare minimum is to allow tokens to be set from an enum and ignore section-* values. The best option is to allow any valid value and make autocomplete a String member (this should be our default best option for any new attribute we have to expose as it reduces the abstraction of the abstraction layer).

The components which are affected are:

  • WDateField
  • WDropdown (see note below)
  • WEmailField (see note below)
  • WMultiDropdown
  • WMultiSelect
  • WMultiTextField
  • WPasswordField
  • WPhoneNumberField (see note below)
  • WNumberField
  • WSingleSelect
  • WTextField (see note below)

Notes

  1. autocomplete must be off (and therefore any other option[s] will not be supported in the client) for:

    • any WTextField, WEmailField or WPhoneNumberField which is associated with a WSuggestions;
    • WPartialDateField; and
    • WDropdown in the COMBO state.
  2. Autocomplete causes some obscure bugs in IE (8 and before, possibly later) and so it is deemed incompatible with that browser. If an implementation needs IE support we cannot (necessarily) provide autocomplete support.

  3. I very much doubt that autocomplete could be sensibly or appropriately used on WMultiTextField or WMultiDropdown so these could be a binary on/offwhere on is the default and not output in the XML.

  4. autocomplete is not useful for WShuffler or WMultiSelectPair and will be set to 'off' in the select elements in these components.

@ghost ghost added the enhancement label Dec 5, 2016
@ghost ghost added this to the 1.3.0 milestone Dec 5, 2016
@ghost ghost assigned jonathanaustin and ghost Dec 5, 2016
@ghost
Copy link
Author

ghost commented Dec 5, 2016

@ghost ghost modified the milestones: V2, 1.3.0 Dec 7, 2016
@ghost ghost mentioned this issue Mar 1, 2017
@ghost ghost closed this as completed Mar 28, 2018
@ghost ghost reopened this Mar 28, 2018
@ghost ghost removed this from the V2 milestone Jul 30, 2018
@ghost ghost added Feature request and removed enhancement labels Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant