Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

CommandShopUI!! #10

Open
nasiridrishi opened this issue Nov 22, 2017 · 19 comments
Open

CommandShopUI!! #10

nasiridrishi opened this issue Nov 22, 2017 · 19 comments

Comments

@nasiridrishi
Copy link

Brief description

Its not an issue but it would be awesome if you can dev it as UI based command shop!!

Steps to reproduce

  1. ...
  2. ...
  3. ...

Expected result

Actual result

Server Information

  • CommandShop Version:
  • Software Version:
  • Server OS:

CrashDumps/Errors

Paste your CrashDump or error by replacing this text (DON'T delete the backticks!)
@HimbeersaftLP
Copy link
Member

You aren't the first with that idea, but I'll be waiting for PMMP's integrated to be merged to master

@AvgZing
Copy link
Member

AvgZing commented Nov 22, 2017

Actually, I'll try to start teaching the BOD team how to efficiently make UIs. This isn't too hard to do.

@HimbeersaftLP
Copy link
Member

@TheRoyalBlock I know you can directly use JSON, but I'd rather use the API because we won't have to change that much if MCPE changes the format.

@AvgZing
Copy link
Member

AvgZing commented Nov 22, 2017

Erm.... There is an API...

@HimbeersaftLP
Copy link
Member

Nope

@HimbeersaftLP
Copy link
Member

HimbeersaftLP commented Nov 22, 2017

pmmp/PocketMine-MP#1476 Still W.I.P.

@AvgZing
Copy link
Member

AvgZing commented Nov 22, 2017

@HimbeersaftLP
Copy link
Member

The first one uses a nonexistent function on a Player object (probably made for a fork?)
The second one uses a super complicated method to do it manually (as I said above you can directly use JSON)

@AvgZing
Copy link
Member

AvgZing commented Nov 22, 2017

The WorldTpUI one is not complicated, I can explain it.

@AvgZing
Copy link
Member

AvgZing commented Nov 22, 2017

And the second one uses both of these:

https://github.com/thebigsmileXD/customui
https://github.com/thebigsmileXD/WarpUI

@HimbeersaftLP
Copy link
Member

The WorldTpUI one is not complicated, I can explain it.

I know how it works, it's just a lot of code which wouldn't be needed of we could use a builtin API and that has to be updated every time Mojang decides to change something.

@AvgZing
Copy link
Member

AvgZing commented Nov 22, 2017

Mojang changes it less frequently than Pocketmine does, and we already update this plugin every time pocketmine changes

@HimbeersaftLP
Copy link
Member

How about we just make our code for the unfinished API? It's surely not going to take a decade for that PR to get merged.

Mojang changes it less frequently than Pocketmine does

*cough* *cough*

@AvgZing
Copy link
Member

AvgZing commented Nov 22, 2017

I'm not so sure about that... Many PM PRs take weeks or even months... But good idea!

@HimbeersaftLP
Copy link
Member

Even if we knew it will take months, we could just make the base plugin, and if the pr still isn't merged, it isn't that hard to add our own UI implementation.
So, should CommandShopUI be a seperate plugin?

@AvgZing
Copy link
Member

AvgZing commented Nov 22, 2017

Yea

@Artistic-Waffle
Copy link

lol yeah

@LeoBdt
Copy link

LeoBdt commented May 3, 2019

???? news?

@HimbeersaftLP
Copy link
Member

When the rewrite is finished, making a CommandShopUI plugin that uses the new CommandShop API should be fairly easy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants