From f9da55cca2eda56ad2e35f654272c257d378d907 Mon Sep 17 00:00:00 2001 From: Ruben Bridgewater Date: Tue, 26 Mar 2019 02:51:13 +0100 Subject: [PATCH] test: remove test-path-parse-6229.js from known issues MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This test precedented the official documentation that states that this is an expected behavior. PR-URL: https://github.com/nodejs/node/pull/26913 Refs: https://github.com/nodejs/node/issues/6229 Refs: https://github.com/nodejs/node/pull/12181 Reviewed-By: Rich Trott Reviewed-By: Michaël Zasso --- test/known_issues/test-path-parse-6229.js | 34 ----------------------- 1 file changed, 34 deletions(-) delete mode 100644 test/known_issues/test-path-parse-6229.js diff --git a/test/known_issues/test-path-parse-6229.js b/test/known_issues/test-path-parse-6229.js deleted file mode 100644 index 5096a97333159d..00000000000000 --- a/test/known_issues/test-path-parse-6229.js +++ /dev/null @@ -1,34 +0,0 @@ -'use strict'; -// Refs: https://github.com/nodejs/node/issues/6229 - -require('../common'); -const assert = require('assert'); -const path = require('path'); - -{ - // The path `/foo/bar` is not the same path as `/foo/bar/` - const parsed1 = path.posix.parse('/foo/bar'); - const parsed2 = path.posix.parse('/foo/bar/'); - - assert.strictEqual(parsed1.root, '/'); - assert.strictEqual(parsed1.dir, '/foo'); - assert.strictEqual(parsed1.base, 'bar'); - - assert.strictEqual(parsed2.root, '/'); - assert.strictEqual(parsed2.dir, '/foo/bar'); - assert.strictEqual(parsed2.base, ''); -} - -{ - // The path `\\foo\\bar` is not the same path as `\\foo\\bar\\` - const parsed1 = path.win32.parse('\\foo\\bar'); - const parsed2 = path.win32.parse('\\foo\\bar\\'); - - assert.strictEqual(parsed1.root, '\\'); - assert.strictEqual(parsed1.dir, '\\foo'); - assert.strictEqual(parsed1.base, 'bar'); - - assert.strictEqual(parsed2.root, '\\'); - assert.strictEqual(parsed2.dir, '\\foo\\bar'); - assert.strictEqual(parsed2.base, ''); -}