Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for key lookup problems is vague/misleading #231

Open
j3parker opened this issue Mar 18, 2022 · 1 comment
Open

Error message for key lookup problems is vague/misleading #231

j3parker opened this issue Mar 18, 2022 · 1 comment

Comments

@j3parker
Copy link
Member

We have a single error message for failures to look up a remote key. Something like: "remote key xyz at URL abc could not be found".
This covers the following problems if I remember correctly:

  • Failure to resolve DNS
  • Failure to connect (TCP)
  • Failure to negotiate a TLS connection
  • Failure to find the key (404)
  • Key is expired

That last one burned us recently: a customer's key expired/wasn't rotated in time, and this lead to an outage for them. We worked from the bottom-up to diagnose this because we didn't notice that the exp timestamp on their key was old, and this delayed resolving the issue. If we had a more informative error message we could have resolved this much quicker.

@j3parker
Copy link
Member Author

We don't error on this but it might be worth doing something similar to https://github.com/Brightspace/oauth2/issues/2487 i.e. rejecting keys where the exp value is "clearly" in milliseconds. This could help e2e with LTI integrations where the integration is first being built against D2L. An exp value in milliseconds will mistakenly be treated as expiring in thousands of years but it would be reasonable to set an upper bound and reject the key, with that hint if it looks like milliseconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant