From 0ddeb7cf8e97aff54f2fb315da8a3cc34a19ba48 Mon Sep 17 00:00:00 2001
From: LongYinan <lynweklm@gmail.com>
Date: Thu, 2 Jun 2022 14:29:49 +0800
Subject: [PATCH] fix: do nothing if lineTo parameters invalid

---
 __test__/draw.spec.ts                            |  11 +++++++++++
 __test__/snapshots/lineTo-with-invalid-point.png | Bin 0 -> 1488 bytes
 src/ctx.rs                                       |  14 ++++++++++----
 3 files changed, 21 insertions(+), 4 deletions(-)
 create mode 100644 __test__/snapshots/lineTo-with-invalid-point.png

diff --git a/__test__/draw.spec.ts b/__test__/draw.spec.ts
index 0eab7ab8..5b1749bc 100644
--- a/__test__/draw.spec.ts
+++ b/__test__/draw.spec.ts
@@ -570,6 +570,17 @@ test('lineTo', async (t) => {
   await snapshotImage(t)
 })
 
+test('lineTo-with-invalid-point', async (t) => {
+  const { ctx } = t.context
+  ctx.beginPath() // Start a new path
+  ctx.lineTo(NaN, 100)
+  ctx.lineTo(50, 50)
+  ctx.lineTo(100, NaN)
+  ctx.lineTo(250, 100)
+  ctx.stroke()
+  await snapshotImage(t)
+})
+
 test('measureText', (t) => {
   const { ctx } = t.context
   ctx.font = '50px Iosevka Slab'
diff --git a/__test__/snapshots/lineTo-with-invalid-point.png b/__test__/snapshots/lineTo-with-invalid-point.png
new file mode 100644
index 0000000000000000000000000000000000000000..7de175b6d4ca099643638cbf31542530a947fe64
GIT binary patch
literal 1488
zcmeIw-%C?r7zgn0PDedQGLC0mgpE?RP6#q8(tZ%Djnz6AZ6b;TFLn?iVj~uo&06rf
zZW6LU38_}mjnT#CE(%8k9l@Yb2a!}4T?`CHwAIRfSZMUT`yads-<!|-e0k6F{@@I^
z`+aq_4YdI3^yA(RK%l7rshap6Tlhm*`a66cq;s~9REYf^y;GtQm-?;%RTp%xyEB$7
zy_r5^b;J8gQx9(5Gc;Fhe=(z}`<HuXt2{eOpXYKHyDoiM3{Zo$9l_i$N9elCg5swG
zFT<nbjzGPLa(C#OD>J11{(1V@*h+jVR1+82{p4;qTN8jQ*i@OY=cz3iZ*arx70r_)
zjmUox&2!v7(Jb+t>Qye)i}WR%mRYHy#8$bNWmd`W$n5K0sz*qk*I2Q1O0?j-ils2Q
zPetLiBp|Jz@RoE+><6tk1_gFZL5mO3hji)(JCU8>+L7(DOPHX#n`=kx5v|)8K;|*m
zhs+dd^CQahq940%krDC<c_;~^jjoZs4P$_N6Zr^TBYFe*B3T}W(Mmb(JXtTA2@&xH
zNiZw|{-&swWn@p-C1zC+y+`e=D#}4xt~J8wA*&rQLR@+%o^PVOg&ZIwWE<%uw;h4`
zp0>kmcyzmdckHP)sDC^AZY%Q2e2=oWf5m$D^%wZhUSMVNa8qHq`D)6xf!|C&>i4ES
GM&ciB{<t&%

literal 0
HcmV?d00001

diff --git a/src/ctx.rs b/src/ctx.rs
index 08e8b56f..a4bcbb2c 100644
--- a/src/ctx.rs
+++ b/src/ctx.rs
@@ -1326,10 +1326,16 @@ fn line_to(ctx: CallContext) -> Result<JsUndefined> {
   let this = ctx.this_unchecked::<JsObject>();
   let context_2d = ctx.env.unwrap::<Context>(&this)?;
 
-  let x = ctx.get::<JsNumber>(0)?.get_double()? as f32;
-  let y = ctx.get::<JsNumber>(1)?.get_double()? as f32;
-
-  context_2d.path.line_to(x, y);
+  if let Ok((x, y)) = ctx.get::<JsNumber>(0)?.get_double().and_then(|x| {
+    ctx
+      .get::<JsNumber>(1)?
+      .get_double()
+      .map(|y| (x as f32, y as f32))
+  }) {
+    if !x.is_nan() && !y.is_nan() {
+      context_2d.path.line_to(x, y);
+    }
+  }
 
   ctx.env.get_undefined()
 }