Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build with Clang 16 #3027

Open
1 task
hawkeye116477 opened this issue May 4, 2023 · 3 comments
Open
1 task

Can't build with Clang 16 #3027

hawkeye116477 opened this issue May 4, 2023 · 3 comments
Labels

Comments

@hawkeye116477
Copy link
Contributor

hawkeye116477 commented May 4, 2023

What happened?

There are errors when trying to build with Clang 16, which is available in Fedora 38 and seems that's related with rust-lang/rust-bindgen#2312. It's already fixed in latest Firefox non-ESR. Looks like that maybe updating bindgen to 0.64 or patching will be needed.

Reproducible?

  • I have tested this on Firefox.

Version

G5

What platform are you seeing the problem on?

Linux

Relevant log output

No response

@MrAlex94
Copy link
Collaborator

MrAlex94 commented May 5, 2023

I've started work on the next ESR (and also testing out rolling releases) in future, but will check what's going on with esr102.

@MrAlex94
Copy link
Collaborator

MrAlex94 commented May 9, 2023

I’ve fixed an issue with rust 1.69 in the meanwhile.

@hawkeye116477 - I’ve pushed some changes to bindgen, do you want to see if that also fixes it for clang 16?

@hawkeye116477
Copy link
Contributor Author

Unfortunately for Clang 16 that's not enough, these changes are needed => https://github.com/rust-lang/rust-bindgen/pull/2319/files, so as I said, it must be v0.64 (that looks like a lot to update) or manual patching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants