Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include custom components subFields inputs for translation #3758

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Include custom components subFields inputs for translation #3758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98254e3
fix getTranslateableFields to handle custom component input subFields
murtaza-builder Nov 27, 2024
afcfe6b
fix applyTranslation for custom component subField inputs
murtaza-builder Nov 27, 2024
95d50ec
handles array cases as well
murtaza-builder Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 83 additions & 0 deletions packages/utils/src/__snapshots__/translation-helpers.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,64 @@ Object {
"translated": true,
},
},
Object {
"@type": "@builder.io/sdk:Element",
"@version": 2,
"component": Object {
"name": "myFunComponent",
"options": Object {
"listItems": Array [
Object {
"field1": Object {
"@type": "@builder.io/core:LocalizedValue",
"Default": "<p>text 1 value</p>",
"de": "<p>german - text 1 value</p>",
"fr-FR": "<p>french - text 1 value</p>",
},
"field2": "field 2 value",
},
Object {
"field1": Object {
"@type": "@builder.io/core:LocalizedValue",
"Default": "<p>text 1.1 value</p>",
"de": "<p>german - text 1.1 value</p>",
"fr-FR": "<p>french - text 1.1 value</p>",
},
"field2": "field 2.1 value",
},
],
"text": "Hello, Builder!",
"title": Object {
"text": Object {
"@type": "@builder.io/core:LocalizedValue",
"Default": "<p>custom component subField input</p>",
"de": "<p>german - custom component subField input</p>",
"fr-FR": "<p>french - custom component subField input</p>",
},
},
},
},
"id": "builder-23e0618256ab40799ecf6504bc57fa1c",
"meta": Object {
"localizedTextInputs": Array [
"title.text",
"listItems.0.field1",
"listItems.1.field1",
],
"transformed.title.text": "localized",
"translated": true,
},
"responsiveStyles": Object {
"large": Object {
"boxSizing": "border-box",
"display": "flex",
"flexDirection": "column",
"flexShrink": "0",
"marginTop": "20px",
"position": "relative",
},
},
},
],
"seo": Object {
"@type": "@builder.io/core:LocalizedValue",
Expand Down Expand Up @@ -328,3 +386,28 @@ Object {
},
}
`;

exports[`getTranslateableFields from carousel content and custom component with subFields to match snapshot 1`] = `
Object {
"blocks.builder-06d3f6da74fb4054ad311afc1dda3675#text": Object {
"instructions": "Visit https://builder.io/fiddle/... for more details",
"value": "<p>I am slide second</p>",
},
"blocks.builder-0a10ae48b6314221bbb7d06d068d623d#text": Object {
"instructions": "Visit https://builder.io/fiddle/... for more details",
"value": "<p>I am slide 1</p>",
},
"blocks.builder-23e0618256ab40799ecf6504bc57fa1c#listItems.0.field1": Object {
"instructions": "Visit https://builder.io/fiddle/... for more details",
"value": "<p>text 1 value</p>",
},
"blocks.builder-23e0618256ab40799ecf6504bc57fa1c#listItems.1.field1": Object {
"instructions": "Visit https://builder.io/fiddle/... for more details",
"value": "<p>text 1.1 value</p>",
},
"blocks.builder-23e0618256ab40799ecf6504bc57fa1c#title.text": Object {
"instructions": "Visit https://builder.io/fiddle/... for more details",
"value": "<p>custom component subField input</p>",
},
}
`;
Loading
Loading