Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interrupting ripgrep causes to affect terminal colors. Windows #430

Closed
DoumanAsh opened this issue Mar 31, 2017 · 3 comments
Closed

Interrupting ripgrep causes to affect terminal colors. Windows #430

DoumanAsh opened this issue Mar 31, 2017 · 3 comments

Comments

@DoumanAsh
Copy link
Contributor

DoumanAsh commented Mar 31, 2017

I'm not sure how exactly coloring is made on Windows but you can Crtl-C ripgrep and it gets your console like that:

http://i.imgur.com/PR0wrCe.png

All non-colored fonts became red for example.
It can happen with any color that ripgrep is using just interrupt it in the moment when coloring starts...

P.s. workaround for powershell:

[Console]::ResetColor()
@DoumanAsh
Copy link
Contributor Author

Ok, sorry i haven't looked properly and found de5cb7d

But no, it is bad. Really bad for user.
You cannot expect user to do clean-up after software.

@BurntSushi
Copy link
Owner

I reopened #281. Please use that and suggest a path forward. I don't need to be told that it is not desirable. I need help to figure out how to fix it.

@DoumanAsh
Copy link
Contributor Author

Ok, i'm sorry i didn't mean to be rude. But i was surprised to see that issue is closed while bad fix has been reverted.
I'm planning to look into possible ways to deal with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants