Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different behaviors between rg, ag and grep #959

Closed
hongxuchen opened this issue Jun 22, 2018 · 1 comment
Closed

Different behaviors between rg, ag and grep #959

hongxuchen opened this issue Jun 22, 2018 · 1 comment
Labels
duplicate An issue that is duplicative of another.

Comments

@hongxuchen
Copy link

This is not a big issue however I would like to make it clear.
For now rg's behavior (also ag) is different from grep when matching text in binary files that contains a bunch of text: by default rg/ag will not match text when it determines that the file is a binary, but grep will still have a try.

As an example, for the file below:
rg_grep_ag.txt
2018-06-22-150654_1409x172_scrot
@BurntSushi
Copy link
Owner

Yes, ripgrep specifically skips binary files. This is part of its filtering logic.

Duplicate of #306 and/or #855.

@BurntSushi BurntSushi added the duplicate An issue that is duplicative of another. label Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate An issue that is duplicative of another.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BurntSushi @hongxuchen