Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size is silly small on MacOS after upgrade to v0.5.0 #37

Open
maltfield opened this issue Oct 6, 2022 · 4 comments
Open

Font size is silly small on MacOS after upgrade to v0.5.0 #37

maltfield opened this issue Oct 6, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@maltfield
Copy link
Member

maltfield commented Oct 6, 2022

Describe the bug

For some reason, the font size on MacOS after upgrading the BusKill app to v0.5.0 is really small

To Reproduce
Steps to reproduce the behavior:

  1. Download the BusKill app v0.5.0
  2. Open the BusKill app
  3. Struggle to read font

Expected behavior

The font size should be reasonably large and easy-to-read. If needed, the user should be able to increase the font size, as needed.

Screenshots

Versions (please complete the following information):

  • OS: MacOS running Monterey (12.6) (MacBook Pro)
  • BusKill: v0.5.0

Additional context
Add any other context about the problem here.

@maltfield
Copy link
Member Author

Until we implement #16 and add an option to the GUI for the user to be able to modify the font size of the app as a more-permanent workaround to this bug and the problem more generally (also good for accessibility), it appears that the user might be able to modify the font size used by kivy by manually editing the kivy config file's font options:

@maltfield
Copy link
Member Author

I noticed on Sam's recent video drafts that these fonts are silly small:

  1. The text in the Action Bar = Settings or Trigger
  2. The text on the Arm and Disarm buttons (and the text above it)

While these fonts are sized as-desired:

  1. The contents of the settings screen
  2. The ActionBar overflow (eg Reset on the Settings window)

TODO: Look for differences in the above widgets to see why some of the text is smaller that the others

@maltfield
Copy link
Member Author

maltfield commented Mar 16, 2024

It looks like my newer settings window options use font RobotoMedium size 18

Whereas the older things like the contents of the Arm button are Roboto size 16

I've also seen use of RobotMeidum size 20 (dialog confirmation title) and RobotoMedium size 16 (in the Navigation Drawer) and RobotoMono size dp(12).

Actually, I wonder if the last one caused the issue.

buskill-app/src/buskill.kv

Lines 249 to 254 in 53f631d

<DebugLogLines@Label>:
text: "Loading Log. Please wait."
size_hint_x: None
width: self.texture_size[0]
font_name: "RobotoMono"
font_size: dp(12)

The above line was committed on 2022-06-11.

  1. v0.4.0 was tagged 2020-10-16
  2. v0.5.0 was tagged 2022-12-27

Therefore, if this bug was introduced in v0.5.0, I think the addition of this dp() sized font is the culprit! Perhaps kivy changes the way fonts are registered once you include a font with dp() values?

@maltfield
Copy link
Member Author

I just stumbled on this python module that auto-sizes text font sizes as the window size increases

maltfield added a commit that referenced this issue Mar 16, 2024
Kivy "sp" font units are "a special Kivy syntax, the sp units automatically scale the font size according to the DPI of the display and the user’s font size setting (on some platforms)"

Source: https://blog.kivy.org/2019/12/kivy-tutorial-002-improving-appearance-customising-widgets-using-kivy-properties/

I'm hoping this fixes issues with silly small font sizes on some MacOS systems

 * #37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant