Merge branch 'global-lints'

GitoxideLabs · Aug 24, 2024 · 37ba461 · 37ba461
2 parents db147b9 + 7083b7a
commit 37ba461
Show file tree

Hide file tree

Showing 102 changed files with 300 additions and 77 deletions.
diff --git a/.cargo/config.toml b/.cargo/config.toml
diff --git a/Cargo.toml b/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gitoxide"
 description = "A command-line application for interacting with git repositories"
@@ -311,3 +313,79 @@ features = ["document-features", "max"]
 [package.metadata.binstall]
 pkg-url = "{ repo }/releases/download/v{ version }/gitoxide-max-pure-v{ version }-{ target }{ archive-suffix }"
 bin-dir = "gitoxide-max-pure-v{ version }-{ target }/{ bin }{ binary-ext }"
+
+[workspace.lints.rust]
+# TODO: enable this
+# unused_qualifications = "warn"
+
+[workspace.lints.clippy]
+pedantic = { level = "warn", priority = -1 }
+#
+# Reviewed and allowed lints
+enum_glob_use = "allow"  # x97
+missing_errors_doc = "allow"  # x1792
+missing_panics_doc = "allow"  # x447
+module_name_repetitions = "allow"  # x125
+must_use_candidate = "allow"  # x1696
+#
+# Lints that we may want to forbid in the future
+default_trait_access = "allow"  # x709
+doc_markdown = "allow"  # x552
+cast_possible_truncation = "allow"  # x216
+needless_pass_by_value = "allow"  # x205
+return_self_not_must_use = "allow"  # x204
+unreadable_literal = "allow"  # x169
+items_after_statements = "allow"  # x164
+single_match_else = "allow"  # x162
+too_many_lines = "allow"  # x161
+unnecessary_wraps = "allow"  # x110
+match_same_arms = "allow"  # x99
+cast_lossless = "allow"  # x91
+ignored_unit_patterns = "allow"  # x80
+used_underscore_binding = "allow"  # x75
+needless_raw_string_hashes = "allow"  # x75
+implicit_clone = "allow"  # x70
+manual_let_else = "allow"  # x64
+cast_precision_loss = "allow"  # x56
+trivially_copy_pass_by_ref = "allow"  # x43
+redundant_else = "allow"  # x42
+if_not_else = "allow"  # x37
+match_wildcard_for_single_variants = "allow"  # x35
+cast_sign_loss = "allow"  # x35
+similar_names = "allow"  # x32
+struct_excessive_bools = "allow"  # x29
+cast_possible_wrap = "allow"  # x26
+explicit_iter_loop = "allow"  # x24
+explicit_into_iter_loop = "allow"  # x22
+explicit_deref_methods = "allow"  # x22
+inconsistent_struct_constructor = "allow"  # x18
+range_plus_one = "allow"  # x17
+inefficient_to_string = "allow"  # x14
+from_iter_instead_of_collect = "allow"  # x13
+unused_self = "allow"  # x10
+many_single_char_names = "allow"  # x10
+manual_string_new = "allow"  # x10
+iter_not_returning_iterator = "allow"  # x10
+option_option = "allow"  # x9
+inline_always = "allow"  # x8
+manual_assert = "allow"  # x7
+iter_without_into_iter = "allow"  # x6
+copy_iterator = "allow"  # x6
+should_panic_without_expect = "allow"  # x5
+transmute_ptr_to_ptr = "allow"  # x4
+match_wild_err_arm = "allow"  # x4
+manual_is_variant_and = "allow"  # x4
+bool_to_int_with_if = "allow"  # x4
+struct_field_names = "allow"  # x3
+wildcard_imports = "allow"  # x2
+needless_for_each = "allow"  # x2
+naive_bytecount = "allow"  # x2
+mut_mut = "allow"  # x2
+match_bool = "allow"  # x2
+fn_params_excessive_bools = "allow"  # x2
+filter_map_next = "allow"  # x2
+checked_conversions = "allow"  # x2
+borrow_as_ptr = "allow"  # x2
+unnecessary_join = "allow"  # x1
+stable_sort_primitive = "allow"  # x1
+no_effect_underscore_binding = "allow"  # x1
diff --git a/gitoxide-core/Cargo.toml b/gitoxide-core/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gitoxide-core"
 description = "The library implementing all capabilities of the gitoxide CLI"

diff --git a/gix-actor/Cargo.toml b/gix-actor/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-actor"
 version = "0.32.0"

diff --git a/gix-archive/Cargo.toml b/gix-archive/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-archive"
 version = "0.15.0"

diff --git a/gix-attributes/Cargo.toml b/gix-attributes/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-attributes"
 version = "0.22.5"

diff --git a/gix-attributes/fuzz/Cargo.toml b/gix-attributes/fuzz/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-attributes-fuzz"
 version = "0.0.0"

diff --git a/gix-bitmap/Cargo.toml b/gix-bitmap/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-bitmap"
 version = "0.2.11"
@@ -17,4 +19,4 @@ test = true
 thiserror = "1.0.38"
 
 [dev-dependencies]
-gix-testtools = { path = "../tests/tools"}
+gix-testtools = { path = "../tests/tools" }
diff --git a/gix-blame/Cargo.toml b/gix-blame/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-blame"
 version = "0.0.0"

diff --git a/gix-chunk/Cargo.toml b/gix-chunk/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-chunk"
 version = "0.4.8"

diff --git a/gix-command/Cargo.toml b/gix-command/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-command"
 version = "0.3.9"

diff --git a/gix-commitgraph/Cargo.toml b/gix-commitgraph/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-commitgraph"
 version = "0.24.3"

diff --git a/gix-commitgraph/fuzz/Cargo.toml b/gix-commitgraph/fuzz/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-commitgraph-fuzz"
 version = "0.0.0"

diff --git a/gix-config-value/Cargo.toml b/gix-config-value/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-config-value"
 version = "0.14.8"

diff --git a/gix-config-value/fuzz/Cargo.toml b/gix-config-value/fuzz/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-config-value-fuzz"
 version = "0.0.0"

diff --git a/gix-config/Cargo.toml b/gix-config/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-config"
 version = "0.40.0"

diff --git a/gix-config/fuzz/Cargo.toml b/gix-config/fuzz/Cargo.toml
@@ -1,3 +1,4 @@
+lints.workspace = true
 
 [package]
 name = "gix-config-fuzz"

diff --git a/gix-config/tests/Cargo.toml b/gix-config/tests/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-config-tests"
 version = "0.0.0"
@@ -29,4 +31,4 @@ serial_test = { version = "3.1.0", default-features = false }
 bstr = { version = "1.3.0", default-features = false, features = ["std"] }
 
 bytesize = "1.3.0"
-cap = { version = "0.1.2", features = ["stats"] }
+cap = { version = "0.1.2", features = ["stats"] }
diff --git a/gix-credentials/Cargo.toml b/gix-credentials/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-credentials"
 version = "0.24.5"

diff --git a/gix-date/Cargo.toml b/gix-date/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-date"
 version = "0.9.0"

diff --git a/gix-date/fuzz/Cargo.toml b/gix-date/fuzz/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-date-fuzz"
 version = "0.0.0"

diff --git a/gix-diff/Cargo.toml b/gix-diff/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-diff"
 version = "0.46.0"

diff --git a/gix-diff/tests/Cargo.toml b/gix-diff/tests/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-diff-tests"
 version = "0.0.0"

diff --git a/gix-dir/Cargo.toml b/gix-dir/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-dir"
 version = "0.8.0"

diff --git a/gix-discover/Cargo.toml b/gix-discover/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-discover"
 version = "0.35.0"

diff --git a/gix-features/Cargo.toml b/gix-features/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-features"
 description = "A crate to integrate various capabilities using compile-time feature flags"

diff --git a/gix-features/src/hash.rs b/gix-features/src/hash.rs
@@ -14,7 +14,7 @@ mod _impl {
     impl Sha1 {
         /// Digest the given `bytes`.
         pub fn update(&mut self, bytes: &[u8]) {
-            self.0.update(bytes)
+            self.0.update(bytes);
         }
         /// Finalize the hash and produce a digest.
         pub fn digest(self) -> Sha1Digest {

diff --git a/gix-features/tests/hash.rs b/gix-features/tests/hash.rs
@@ -3,7 +3,7 @@ use gix_features::hash::Sha1;
 #[cfg(not(feature = "fast-sha1"))]
 #[test]
 fn size_of_sha1() {
-    assert_eq!(std::mem::size_of::<Sha1>(), 96)
+    assert_eq!(std::mem::size_of::<Sha1>(), 96);
 }
 
 #[cfg(feature = "fast-sha1")]

diff --git a/gix-fetchhead/Cargo.toml b/gix-fetchhead/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-fetchhead"
 version = "0.0.0"

diff --git a/gix-filter/Cargo.toml b/gix-filter/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-filter"
 version = "0.13.0"

diff --git a/gix-fs/Cargo.toml b/gix-fs/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-fs"
 version = "0.11.3"

diff --git a/gix-fsck/Cargo.toml b/gix-fsck/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-fsck"
 version = "0.6.0"
@@ -19,4 +21,4 @@ gix-object = { version = "^0.44.0", path = "../gix-object" }
 
 [dev-dependencies]
 gix-odb = { path = "../gix-odb" }
-gix-testtools = { path = "../tests/tools"}
+gix-testtools = { path = "../tests/tools" }
diff --git a/gix-glob/Cargo.toml b/gix-glob/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-glob"
 version = "0.16.5"

diff --git a/gix-hash/Cargo.toml b/gix-hash/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-hash"
 version = "0.14.2"

diff --git a/gix-hashtable/Cargo.toml b/gix-hashtable/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-hashtable"
 version = "0.5.2"
@@ -15,8 +17,7 @@ doctest = false
 [dependencies]
 parking_lot = "0.12.1"
 hashbrown = { version = "0.14.0", default-features = false, features = [
-  "inline-more",
-  "raw"
+    "inline-more",
+    "raw"
 ] }
 gix-hash = { version = "^0.14.2", path = "../gix-hash" }
-
diff --git a/gix-ignore/Cargo.toml b/gix-ignore/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-ignore"
 version = "0.11.4"

diff --git a/gix-index/Cargo.toml b/gix-index/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-index"
 version = "0.35.0"

diff --git a/gix-index/tests/Cargo.toml b/gix-index/tests/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-index-tests"
 version = "0.0.0"

diff --git a/gix-lfs/Cargo.toml b/gix-lfs/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-lfs"
 version = "0.0.0"

diff --git a/gix-lock/Cargo.toml b/gix-lock/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-lock"
 version = "14.0.0"

diff --git a/gix-macros/Cargo.toml b/gix-macros/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-macros"
 version = "0.1.5"

diff --git a/gix-mailmap/Cargo.toml b/gix-mailmap/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-mailmap"
 version = "0.24.0"

diff --git a/gix-negotiate/Cargo.toml b/gix-negotiate/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-negotiate"
 version = "0.15.0"

diff --git a/gix-note/Cargo.toml b/gix-note/Cargo.toml
@@ -1,3 +1,5 @@
+lints.workspace = true
+
 [package]
 name = "gix-note"
 version = "0.0.0"