-
-
Notifications
You must be signed in to change notification settings - Fork 311
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor configuration handling to allow pre-parsing of common values (…
…#298) Similar to what git does during setup.
- Loading branch information
Showing
8 changed files
with
94 additions
and
66 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,70 @@ | ||
#[derive(Debug, thiserror::Error)] | ||
pub enum Error { | ||
#[error("Could not open repository conifguration file")] | ||
Open(#[from] git_config::parser::ParserOrIoError<'static>), | ||
#[error("Cannot handle objects formatted as {:?}", .name)] | ||
UnsupportedObjectFormat { name: crate::bstr::BString }, | ||
} | ||
|
||
/// Utility type to keep pre-obtained configuration values. | ||
#[derive(Debug, Clone)] | ||
pub(crate) struct Cache { | ||
pub resolved: crate::Config, | ||
/// The hex-length to assume when shortening object ids. If `None`, it should be computed based on the approximate object count. | ||
pub hex_len: Option<u8>, | ||
/// true if the repository is designated as 'bare', without work tree | ||
pub is_bare: bool, | ||
/// The type of hash to use | ||
pub object_hash: git_hash::Kind, | ||
/// If true, multi-pack indices, whether present or not, may be used by the object database. | ||
pub use_multi_pack_index: bool, | ||
} | ||
|
||
mod cache { | ||
use super::{Cache, Error}; | ||
use git_config::file::GitConfig; | ||
use git_config::values::{Boolean, Integer}; | ||
use std::borrow::Cow; | ||
|
||
impl Cache { | ||
pub fn new(git_dir: &std::path::Path) -> Result<Self, Error> { | ||
let config = GitConfig::open(git_dir.join("config"))?; | ||
let is_bare = config_bool(&config, "core.bare", false); | ||
let use_multi_pack_index = config_bool(&config, "core.multiPackIndex", true); | ||
let repo_format_version = config | ||
.value::<Integer>("core", None, "repositoryFormatVersion") | ||
.map_or(0, |v| v.value); | ||
let object_hash = if repo_format_version == 1 { | ||
if let Ok(format) = config.value::<Cow<'_, [u8]>>("extensions", None, "objectFormat") { | ||
match format.as_ref() { | ||
b"sha1" => git_hash::Kind::Sha1, | ||
_ => { | ||
return Err(Error::UnsupportedObjectFormat { | ||
name: format.to_vec().into(), | ||
}) | ||
} | ||
} | ||
} else { | ||
git_hash::Kind::Sha1 | ||
} | ||
} else { | ||
git_hash::Kind::Sha1 | ||
}; | ||
|
||
Ok(Cache { | ||
resolved: config.into(), | ||
use_multi_pack_index, | ||
object_hash, | ||
is_bare, | ||
hex_len: None, | ||
}) | ||
} | ||
} | ||
|
||
fn config_bool(config: &GitConfig<'_>, key: &str, default: bool) -> bool { | ||
let (section, key) = key.split_once('.').expect("valid section.key format"); | ||
config | ||
.value::<Boolean<'_>>(section, None, key) | ||
.map_or(default, |b| matches!(b, Boolean::True(_))) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters