Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use pyproject.toml #367

Merged
merged 16 commits into from
Dec 10, 2024
Merged

Update to use pyproject.toml #367

merged 16 commits into from
Dec 10, 2024

Conversation

tab-cmd
Copy link
Contributor

@tab-cmd tab-cmd commented Nov 25, 2024

Overview

Refactored to install and build using pyproject toml.

Ticket

https://www.pivotaltracker.com/story/show/188483553
https://www.pivotaltracker.com/story/show/184794336

Contributions

  • Remove old configuration files (pytest.ini, setup.py. etc)
  • Add pyproject.toml
  • Update build commands

Test

  • Install using python 3.9 and test commands
  • TODO: install using python 3.10 and test commands

Documentation

  • Are documentation updates required? In-line, README, or documentation? TODO

Changelog

  • Is the CHANGELOG.md updated with your detailed changes? TODO

@tab-cmd tab-cmd marked this pull request as ready for review December 4, 2024 17:47
@tab-cmd tab-cmd requested a review from lawhead December 4, 2024 17:47
@tab-cmd tab-cmd changed the title Update to using pyproject.toml Update to use pyproject.toml Dec 4, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be happening again with the eyetracker stream, but it's probably okay to remove this script.

"kenlm==0.1",
"pyWinhook==1.6.2;python_version=='3.9' and platform_system=='Windows'",
"WxPython==4.2.1;platform_system!='Linux'",
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add 'rich==13.9.4' to this list?

Copy link

codacy-production bot commented Dec 10, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 6cbbfbc1 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6cbbfbc) Report Missing Report Missing Report Missing
Head commit (51e028d) 8517 5985 70.27%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#367) 3 3 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@tab-cmd tab-cmd merged commit b256aed into 2.0.0 Dec 10, 2024
11 checks passed
@tab-cmd tab-cmd deleted the pyproject branch December 10, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants