Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIDS DSI-24, ET Data, and 1020 support #369

Merged
merged 12 commits into from
Dec 10, 2024
Merged

Conversation

tab-cmd
Copy link
Contributor

@tab-cmd tab-cmd commented Dec 9, 2024

Overview

Cleanup convert methods. Add DSI-24 support. Add 1020 coordinate methods. Add the ability to output eye tracker data. Minor bugfix on install dependencies.

Ticket

https://www.pivotaltracker.com/story/show/186801441
https://www.pivotaltracker.com/story/show/188668716 (data shared in Google Drive)

Contributions

  • convert: add convert et data to BIDS. Modify the demo to handle older data structures.
  • load: cleanup BciPySessionTaskData
  • raw_data: add 1020 methods
  • requirements.txt define PyQt6-sip to permit 3.8 builds

Test

  • make test-all
  • Ran the demo_convert on Matrix Multimodal data and uploaded for NEU.

Documentation

  • Are documentation updates required? In-line, README, or documentation? Done.

Changelog

  • Is the CHANGELOG.md updated with your detailed changes? Yes

@tab-cmd tab-cmd force-pushed the convert_multimodal_dataset branch from 9c32e2c to f8cb33b Compare December 9, 2024 22:53
@tab-cmd tab-cmd changed the title Updates to convert datasets with DSI-24 data BIDS DSI-24, ET Data, and 1020 support Dec 9, 2024
@tab-cmd tab-cmd marked this pull request as ready for review December 9, 2024 22:55
@tab-cmd tab-cmd requested review from lawhead and celikbasak December 9, 2024 22:55
@@ -72,7 +74,7 @@ def ask_filename(

Returns
-------
path to file or None if the user cancelled the dialog.
path to file or raises an exception if the user cancels the dialog.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we always want an exception to be thrown on a dialog cancel. For instance, in GUI applications, a user might initially want to change a path, but then decide to stick with the original value. This would result in a lot of extra error handling.

What about using an additional parameter to specify the behavior? It could either be a boolean indicating whether or not an exception should be thrown (ex. ask_filename(..., strict=True)), or we could provide a default value like a dict.get (ex. ask_filename(..., default='')).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. In most of my use cases, this was the fallback GUI if no path was given. It's helpful to have an error when exiting without a choice in those cases. I'll use the boolean, as you suggest.

@tab-cmd tab-cmd merged commit 6cbbfbc into 2.0.0 Dec 10, 2024
9 checks passed
@tab-cmd tab-cmd deleted the convert_multimodal_dataset branch December 10, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants