-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIDS DSI-24, ET Data, and 1020 support #369
Conversation
TODO: fix DSI-24 case, add method for gaze conversion
9c32e2c
to
f8cb33b
Compare
@@ -72,7 +74,7 @@ def ask_filename( | |||
|
|||
Returns | |||
------- | |||
path to file or None if the user cancelled the dialog. | |||
path to file or raises an exception if the user cancels the dialog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we always want an exception to be thrown on a dialog cancel. For instance, in GUI applications, a user might initially want to change a path, but then decide to stick with the original value. This would result in a lot of extra error handling.
What about using an additional parameter to specify the behavior? It could either be a boolean indicating whether or not an exception should be thrown (ex. ask_filename(..., strict=True)
), or we could provide a default value like a dict.get (ex. ask_filename(..., default='')
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. In most of my use cases, this was the fallback GUI if no path was given. It's helpful to have an error when exiting without a choice in those cases. I'll use the boolean, as you suggest.
Implement where needed
Overview
Cleanup convert methods. Add DSI-24 support. Add 1020 coordinate methods. Add the ability to output eye tracker data. Minor bugfix on install dependencies.
Ticket
https://www.pivotaltracker.com/story/show/186801441
https://www.pivotaltracker.com/story/show/188668716 (data shared in Google Drive)
Contributions
convert
: add convert et data to BIDS. Modify the demo to handle older data structures.load
: cleanup BciPySessionTaskDataraw_data
: add 1020 methodsrequirements.txt
definePyQt6-sip
to permit 3.8 buildsTest
make test-all
Documentation
Changelog