Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor failed summary handling #152

Open
slsevilla opened this issue Apr 4, 2024 · 1 comment
Open

Refactor failed summary handling #152

slsevilla opened this issue Apr 4, 2024 · 1 comment
Assignees
@jvhagey
Labels
Low Severity Bug: Universal Something isn't working, but not wrong or killing pipeline

Comments

@slsevilla
Copy link

Description

I think we can improve the failed summary handling, but I'm not clear on what is the goal of the fetched_failed_summaries module, and since I don't have failed samples for SPADES I'm not able to see the full picture. Can you help me get an idea of what the goal is - I'd be happy to think through a new strategy for these since I THINK that this will trigger a restart of the pipeline upstream if there are failed samples.
@jvhagey
Copy link
Collaborator

jvhagey commented Jun 13, 2024 •
edited
Loading

I made some changes to how this is handled here e5ef2e5 and here
1f8c9e7. Can you give it a try the v2.2.0-dev and see if the resume works correctly now?

@jvhagey jvhagey self-assigned this Jun 13, 2024
@jvhagey jvhagey added the Low Severity Bug: Universal Something isn't working, but not wrong or killing pipeline label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jvhagey jvhagey

Labels
Low Severity Bug: Universal Something isn't working, but not wrong or killing pipeline
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@slsevilla @jvhagey