Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change visc_method default to avg_zeta #738

Closed
Tracked by #660
eclare108213 opened this issue Jul 29, 2022 · 2 comments
Closed
Tracked by #660

change visc_method default to avg_zeta #738

eclare108213 opened this issue Jul 29, 2022 · 2 comments
Assignees
@apcraig
Labels
Dynamics Priority: High

Comments

@eclare108213
Copy link
Contributor

No description provided.

@eclare108213 eclare108213 mentioned this issue Jul 29, 2022
Closed
41 tasks
@apcraig
Copy link
Contributor

apcraig commented Aug 1, 2022

Testing suggests there are gridCD test cases that pass with avg_strength and fail with avg_zeta. This is not a problem for the B or C grid tests and the failing gridCD tests are limited. Running a full test suite now, will update issue shortly.

@apcraig
Copy link
Contributor

apcraig commented Aug 5, 2022

Done in #744

@apcraig apcraig closed this as completed Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apcraig apcraig

Labels
Dynamics Priority: High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eclare108213 @apcraig