Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Certifier] Handle case where fill_number is none, when trying to certify run #127

Closed
nothingface0 opened this issue Apr 25, 2022 · 0 comments
Closed

[Certifier] Handle case where fill_number is none, when trying to certify run #127

nothingface0 opened this issue Apr 25, 2022 · 0 comments

Comments

@nothingface0
Copy link
Contributor

nothingface0 commented Apr 25, 2022 •
edited
Loading

In the very specific case of runs with no fill numbers (e.g. 350716), the procedure retrieve_run in oms/utils.py crashes.

This should either:

  • ✔️ Be ignored and set to None (Need to see if other things break down the line)
    or
  • Stop execution and throw an error to the user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nothingface0