Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print BestResult even if the rgnTimeout is 0 #166

Open
Quincunx271 opened this issue Jul 5, 2021 · 0 comments
Open

Print BestResult even if the rgnTimeout is 0 #166

Quincunx271 opened this issue Jul 5, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@Quincunx271
Copy link
Member

Currently, we don't print the BestResult if the region timeout is 0:

if (rgnTimeout != 0) {
bool optimalSchedule = isLstOptml || (rslt == RES_SUCCESS);
Logger::Event("BestResult", "name", dataDepGraph_->GetDagID(), //
"cost", bestCost_, "length", bestSchedLngth_, //
"optimal", optimalSchedule);
// TODO(justin): Remove once relevant scripts have been updated:
// get-sched-length.py, plaidbench-validation-test.py
Logger::Info("Best schedule for DAG %s has cost %d and length %d. The "
"schedule is %s",
dataDepGraph_->GetDagID(), bestCost_, bestSchedLngth_,
optimalSchedule ? "optimal" : "not optimal");
}

However, region timeouts of 0 can be used to bypass our scheduler. We should still print the BestResult; it should just use the heuristic schedule. Not having the BestResult confuses the validation-test script.

This is not as simple as removing the condition, however, as the optimalSchedule logic must also be updated.

@Quincunx271 Quincunx271 added the good first issue Good for newcomers label Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant