Resolves issue #1157 - Fixes incorrect implementation of character length limitations. #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Issue #1157
Summary
Previously (by me), character length limitations were implemented on the PUT body and not the PUT query parameters. In addition, tests were mistakenly only written for the POST endpoint.
This has been fixed, and now correctly applied to the PUT query parameters, and correct tests have been implemented.
Important Changes
src/controller/org.controller/index.jstest/integration-tests/user/updateUserTest.jsTesting
Steps to manually test updated functionality, if possible
npm run test:integration