Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kerbalCrewMass is added to *every* part when crew are added in the VAB #125

Open
NonWonderDog opened this issue Apr 1, 2017 · 12 comments
Open

Comments

@NonWonderDog
Copy link

KSP has an undocumented parameter in Physics.cfg called kerbalCrewMass. This adds a configurable amount of mass to a crewed part. The mass doesn't show up in the stock Engineer's Report, but it is added in the flight scene.

That's not the bug.

Kerbal Engineer seems to try to account for kerbalCrewMass in the VAB, but it does so incorrectly. When crew is added to a vessel, Kerbal Engineer seems to add kerbalCrewMass to every part on the vessel, instead of just the crewed part. This causes the calculated TWR and delta-V to be significantly incorrect for large crewed vessels.

With kerbalCrewMass set to 0.09375, adding a kerbal to a craft consisting of a single Mk1 pod correctly adds 94 kg to the Kerbal Engineer vessel stats in the VAB. Adding a single kerbal to a craft consisting of a M1 pod and any other part adds 188 kg.

The mass and delta-V are correct in the flight scene.

@Vladimir-csp
Copy link

Confirming this, I also use "corporeal crew" )

@jrbudda
Copy link
Contributor

jrbudda commented Mar 21, 2018

Is this still an issue in 1.4.1? I can't get the kerbalCrewMass value to do anything at all....

@NonWonderDog
Copy link
Author

Seems to work exactly as before in my 1.4.1 install. I set kerbalCrewMass=100 in Physics.cfg, made a 3-part rocket, and couldn't lift off. Engineer reported a mass of 300+ tonnes in the VAB, and the correct mass of 100+ tonnes on the pad.

@jrbudda
Copy link
Contributor

jrbudda commented Mar 21, 2018

ya know I bet I have to change it in ModuleManager.physics and not physics.cfg. That would explain it. In any case KER does not access or attempt to do anything at all with this value as far as I can see. My guess is the mass is added by the game to all parts in the VAB and maybe the vanilla engineer report is subtracting it out.

@jrbudda
Copy link
Contributor

jrbudda commented Mar 22, 2018

Should be fixed. The two of you who play with this setting owe me like 6 hours of my life back. What a mess. https://github.com/jrbudda/KerbalEngineer/releases

@Vladimir-csp
Copy link

Thanks!
I'll test it later today.

@Vladimir-csp
Copy link

Overall mass and Dv calculation seem to be fine now, but part middle-click info box still adds crew mass for every part.

@jrbudda
Copy link
Contributor

jrbudda commented Mar 22, 2018

Yea it's a stock bug I worked around for KER. I can't fix Squad's bug.

@Vladimir-csp
Copy link

Middle click info is KER's feature.

@jrbudda
Copy link
Contributor

jrbudda commented Mar 22, 2018

is it really? lol, goes to show how often I play without it!

@jrbudda
Copy link
Contributor

jrbudda commented Mar 22, 2018

Ok this should have it all fixed.

KerbalEngineer-1.1.4.1b.zip

@Vladimir-csp
Copy link

Vladimir-csp commented Mar 22, 2018

something broke in this one :(
It reverted to previous behavior

Oh, you fixed the link. Everything seems to be working with this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants