Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup, document, centralize wordLang syntactic conventions #1093

Open
tanyongkiam opened this issue Nov 15, 2024 · 0 comments · May be fixed by #1038
Open

Cleanup, document, centralize wordLang syntactic conventions #1093

tanyongkiam opened this issue Nov 15, 2024 · 0 comments · May be fixed by #1038
Labels
dev experience Makes tasks developing cakeml itself easier refactoring

Comments

@tanyongkiam
Copy link
Contributor

tanyongkiam commented Nov 15, 2024

At present, wordLang passes establish/preserve a number of syntactic properties across different phases.

These properties have gotten a bit too much to handle for adding new passes (one often needs to prove several syntactic properties completely unrelated to the semantic correctness proof).

This issue is about taking a first step towards fixing this.

I suggest to create two files:

semantics/word_convTheory which will store all the definitions of syntactic conventions that need to be preserved ACROSS passes in wordLang. Most (or all?) of these are currently in semantics/wordPropsTheory so this is a matter of moving them.

proofs/word_convProofTheory which will store the individual proof of the syntax properties for every pass.

The idea is that, for a new compiler pass, it should be hopefully relatively easy to test that we have met all the necessary syntactic conventions by building word_convProofTheory.

@tanyongkiam tanyongkiam added refactoring dev experience Makes tasks developing cakeml itself easier labels Nov 15, 2024
@ordinarymath ordinarymath linked a pull request Nov 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev experience Makes tasks developing cakeml itself easier refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant