Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entityId under PropertyOrBuilder should not be set when copying a doc #145

Closed
faizanabidnaqvi opened this issue Oct 14, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@faizanabidnaqvi
Copy link

Hi! I found another minor issue; I don't think it is necessarily an issue but more about consistency.

I have some fields that are dependent on whether the entityId has been set (that is the doc exists in firebase). This works fine for editing or creating new docs. When docs are being created, entityId is undefined which makes sense, and when docs are being edited entityId is set to the firebase doc id.

However, when we use the copy feature to create a new doc, the entityId in the copy dialog will be set to the entityId we initiated the copy from. Since some of the fields I have are dependent on whether the entityId is set they don't behave correctly when using the copy feature.

I can also imagine the entityId being useful in the copy scenario but in general, what I am looking for is to check for a property whether entity already exists or not (in the data store). Using entityId is the only way I think; so either entityId should be undefined or there should be another variable in the property builder that can allow us to check if the entity is already set in the data store. I might be making some mistakes here so let me know if there are indeed other ways to check that.

@fgatti675 fgatti675 added the bug Something isn't working label Oct 15, 2021
@fgatti675
Copy link
Member

Fixed in version 1.0.0-beta3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants