Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

302 request allow lightning zap receipts on paid relays #303

Merged
merged 5 commits into from
May 12, 2023
Merged

302 request allow lightning zap receipts on paid relays #303

merged 5 commits into from
May 12, 2023

Conversation

cameri
Copy link
Owner

@cameri cameri commented May 12, 2023 •
edited
Loading

Description

  1. Allow event kinds to be waived for admission fee

Related Issue

#302

Motivation and Context

  1. Allow LN wallet providers to publish zaps to paid relays

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@cameri cameri linked an issue May 12, 2023 that may be closed by this pull request
[REQUEST] Allow Lightning zap receipts on paid relays #302
Closed
@cameri cameri self-assigned this May 12, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4963877766

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.3%) to 56.684%
Totals Coverage Status
Change from base Build 4903072225: 1.3%
Covered Lines: 1232
Relevant Lines: 2137
💛 - Coveralls

@cameri cameri merged commit 3d90834 into main May 12, 2023
@cameri cameri deleted the 302-request-allow-lightning-zap-receipts-on-paid-relays branch May 12, 2023 23:49
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

cameri added a commit that referenced this pull request May 12, 2023
@cameri
feat: allow lightning zap receipts on paid relays (#303)
14bc96f 
* chore: add event_kinds whitelist for fee schedules

* chore: fix identation in default-settings.yml

* chore: waive admission fee for specific event kinds

* docs: add payment settings to CONFIGURATION.md

* docs: improve read replica docs
github-actions bot pushed a commit that referenced this pull request May 12, 2023
@semantic-release-bot
chore(release): 1.23.0 [skip ci]
62c1dbe 
# [1.23.0](v1.22.6...v1.23.0) (2023-05-12)

### Bug Fixes

* add SECRET as env variable ([#298](#298)) ([58a1254](58a1254))
* invoice auto marked as paid ([be6d6f1](be6d6f1))
* issues with invoices ([#271](#271)) ([e1561e7](e1561e7))

### Features

* add LNURL processor ([#202](#202)) ([f237400](f237400))
* allow lightning zap receipts on paid relays ([#303](#303)) ([14bc96f](14bc96f))
cameri pushed a commit that referenced this pull request May 15, 2023
@semantic-release-bot @cameri
chore(release): 1.23.0 [skip ci]
575ef5e 
# [1.23.0](v1.22.6...v1.23.0) (2023-05-12)

### Bug Fixes

* add SECRET as env variable ([#298](#298)) ([58a1254](58a1254))
* invoice auto marked as paid ([be6d6f1](be6d6f1))
* issues with invoices ([#271](#271)) ([e1561e7](e1561e7))

### Features

* add LNURL processor ([#202](#202)) ([f237400](f237400))
* allow lightning zap receipts on paid relays ([#303](#303)) ([14bc96f](14bc96f))
cameri added a commit that referenced this pull request May 15, 2023
@cameri @semantic-release-bot
feat: implement nodeless payments processor (#305)
52aac39 
* chore: hide powered by zebedee if payment processor is not

* chore: add nodeless as payments processor to settings

* fix: bad content type on zebedee callback req handler

* chore(release): 1.23.0 [skip ci]

# [1.23.0](v1.22.6...v1.23.0) (2023-05-12)

### Bug Fixes

* add SECRET as env variable ([#298](#298)) ([58a1254](58a1254))
* invoice auto marked as paid ([be6d6f1](be6d6f1))
* issues with invoices ([#271](#271)) ([e1561e7](e1561e7))

### Features

* add LNURL processor ([#202](#202)) ([f237400](f237400))
* allow lightning zap receipts on paid relays ([#303](#303)) ([14bc96f](14bc96f))

* feat: implement nodeless payments processor

* docs: add accepting payments section

* chore: validate nodeless webhook secret

* chore: hide powered-by-zebedee for non-zebedee processors

---------

Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
github-actions bot pushed a commit that referenced this pull request May 15, 2023
@semantic-release-bot
chore(release): 1.24.0 [skip ci]
123db2c 
# [1.24.0](v1.23.0...v1.24.0) (2023-05-15)

### Features

* implement nodeless payments processor ([#305](#305)) ([52aac39](52aac39)), closes [#298](#298) [#271](#271) [#202](#202) [#303](#303)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cameri cameri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REQUEST] Allow Lightning zap receipts on paid relays
2 participants
@cameri @coveralls