Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generic tag queries not accepting uppercase letters #312

Merged
merged 1 commit into from
May 19, 2023
Merged

fix: generic tag queries not accepting uppercase letters #312

merged 1 commit into from
May 19, 2023

Conversation

cameri
Copy link
Owner

@cameri cameri commented May 19, 2023

Description

Allow generic tag queries to be in uppercase.

Related Issue

#311

Motivation and Context

NIP-12 does not mention tags should be lowercase, meaning uppercase letters should also be allowed.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@cameri cameri linked an issue May 19, 2023 that may be closed by this pull request
Generic Tag Query should include capital letters #311
Closed
@sonarcloud
Copy link

sonarcloud bot commented May 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@cameri cameri merged commit 7331f95 into main May 19, 2023
@cameri cameri deleted the 311-generic-tag-query-should-include-capital-letters branch May 19, 2023 19:23
@cameri cameri self-assigned this May 22, 2023
github-actions bot pushed a commit that referenced this pull request May 23, 2023
@semantic-release-bot
chore(release): 1.25.0 [skip ci]
2335a57 
# [1.25.0](v1.24.1...v1.25.0) (2023-05-23)

### Bug Fixes

* generic tag queries not accepting uppercase letters ([#312](#312)) ([7331f95](7331f95))

### Features

* implement opennode payments processor ([#315](#315)) ([df1a364](df1a364))
@github-actions
Copy link

🎉 This PR is included in version 1.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cameri cameri

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic Tag Query should include capital letters
1 participant
@cameri