Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cropping issue on some devices #414

Closed
ksk-tech opened this issue Jul 26, 2022 · 9 comments
Closed

Cropping issue on some devices #414

ksk-tech opened this issue Jul 26, 2022 · 9 comments

Comments

@ksk-tech
Copy link

  • Lib Version 3.3.6, 4.3.1

Describe the bug
Cropping flow fails in some cases after taking a photo on some devices. We have reproduced it on Samsung devices. Usually it's reproduced if a user switches cameras and then takes a photo, but sometimes we get the same result with no camera switch.
In our app with the lib integrated the following result is logged - cropping has been cancelled by the user

To Reproduce
Steps to reproduce the behavior:

  1. Open the sample app on a Samsung device. The issue is definitely reproduced on Samsung S21+ with Android 12 here - Samsung Remote Test Lab
  2. Click on Sample Calling CropImage -> Call Liabrary Directly Without URI -> Camera -> switch cameras -> take a photo and press OK

Expected behavior
Correct cropping flow

Media

Screen_Recording_SamsungS21+.mp4

Smartphone (please complete the following information):

  • Device: [Samsung S21/S21+]
  • OS: [Android 12]

Additional context
It seems like the context for getting a photo image doesn't survive in most of the cases on Samsung devices.
I have no such issue on Pixel 4A.

@ksk-tech ksk-tech added the bug label Jul 26, 2022
@Canato
Copy link
Member

Canato commented Jul 27, 2022

Back from holidays, will check ASAP

@ksk-tech
Copy link
Author

Hello @Canato, hope you are doing well.
Have you managed to reproduce the issue?

@Canato
Copy link
Member

Canato commented Jul 29, 2022

Hey @ksk-tech not yet. I started a new job as manager on the last weeks

Basically, my time has been reduced a lot. But I didn't forget this.
I just need to find time to make this volunteer work ^^

Sad to say, but capitalism force me to focus where the money comes in hahahaha

@Canato
Copy link
Member

Canato commented Aug 10, 2022

Back this week will take a look. sorry for the long time on this

@Canato
Copy link
Member

Canato commented Aug 15, 2022

@ksk-tech Thanks for raising this and sorry for so long to answer. Last month have being crazy.

Indeed I could reproduce with some devices, but mostly I could not.

Yet, not sure what could cause this, something that Samsung is being annoying with its context/cache
For sure we can do something about it, just need to discover what. And hope they will fix it

@vanniktech
Copy link
Contributor

@ksk-tech have you found any workaround? Is this still happening?

@SidoPillai
Copy link

#355 (comment)

@ksk-tech
Copy link
Author

@vanniktech @Canato it seems like the Samsung Camera app update has fixed the issue.

@vanniktech
Copy link
Contributor

Alright, thanks. Closing this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants