-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] - CropRect has mixed up width / height ⚠️ ⚠️ #439
Comments
Hey welcome 👋 to the library and thanks for the Issue. Can you please follow the I will close 🔴 this issue so you can reopen following the template Is important to remember that my work here is a volunteer and to save time and have better answer help me that people use the templates. Thanks!! 🎉 |
Are you serious? |
Yeah, man, to be fair, if I see an issue without the template, I already send this automated message without reading it. It is for my time management and sanity that I put this type of template to help, sadly I have a limited amount of time. No other people so far have joined me to support this 200k monthly download library, so yeah, sorry that was so abrupt. I don't use this library in any of my projects today, and I support to help the community. I ask just for people to follow the setup I put in place so I can be more effective... as you can see, we have an open PR that I didn't have the time yet to check, and no one else did and probably won't since no one never did before. Indeed your issue is good, just missing the library version, but as a previous contributor, please use the templates and or already drop a PR with a fix. |
Thanks for reopening! Library version is latest, I tried this out on the |
This will NOT be closed by #440 |
Using a Pixel 6 XL.
Camera
as the sourceonSetImageUriComplete
:Android-Image-Cropper/cropper/src/main/java/com/canhub/cropper/CropImageActivity.kt
Line 274 in 85c98bb
Expected behavior:
view.cropRect
should have the correct dimensions (height > width)Actual behavior:
view.cropRect
mixed up height with width (I get width of 3226 & height of 1814)The text was updated successfully, but these errors were encountered: