Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - CropRect has mixed up width / height ⚠️ ⚠️ #439

Closed
vanniktech opened this issue Sep 21, 2022 · 6 comments · Fixed by #496
Closed

[BUG] - CropRect has mixed up width / height ⚠️ ⚠️ #439

vanniktech opened this issue Sep 21, 2022 · 6 comments · Fixed by #496

Comments

@vanniktech
Copy link
Contributor

Using a Pixel 6 XL.

  1. Click on sample of customactivity
  2. Select Camera as the source
  3. Take a portrait! picture
  4. Have a breakpoint in onSetImageUriComplete:

Expected behavior: view.cropRect should have the correct dimensions (height > width)
Actual behavior: view.cropRect mixed up height with width (I get width of 3226 & height of 1814)

@vanniktech vanniktech added the bug label Sep 21, 2022
@vanniktech vanniktech changed the title [BUG] - CropRect has mixed up widht / height ⚠️ ⚠️ [BUG] - CropRect has mixed up width / height ⚠️ ⚠️ Sep 21, 2022
@vanniktech
Copy link
Contributor Author

If you look at the image: BitmapFactory.decodeStream(view.context.contentResolver.openInputStream(uri)) - you can also see that the orientation is messed up:

Screen Shot 2022-09-21 at 19 30 21

@Canato
Copy link
Member

Canato commented Sep 21, 2022

Hey welcome 👋 to the library and thanks for the Issue.

Can you please follow the template we have for issues? 🙏
There are many points on the template that will help me to help you.

I will close 🔴 this issue so you can reopen following the template

Is important to remember that my work here is a volunteer and to save time and have better answer help me that people use the templates.

Thanks!! 🎉

@Canato Canato closed this as completed Sep 21, 2022
@vanniktech
Copy link
Contributor Author

Are you serious?

@Canato
Copy link
Member

Canato commented Sep 22, 2022

Are you serious?

Yeah, man, to be fair, if I see an issue without the template, I already send this automated message without reading it.
I spent too much time doing free volunteer work here and dealing with many people who don't read documentation or FAQ or don't know how to raise an issue.

It is for my time management and sanity that I put this type of template to help, sadly I have a limited amount of time. No other people so far have joined me to support this 200k monthly download library, so yeah, sorry that was so abrupt.

I don't use this library in any of my projects today, and I support to help the community. I ask just for people to follow the setup I put in place so I can be more effective... as you can see, we have an open PR that I didn't have the time yet to check, and no one else did and probably won't since no one never did before.

Indeed your issue is good, just missing the library version, but as a previous contributor, please use the templates and or already drop a PR with a fix.

@Canato Canato reopened this Sep 22, 2022
@vanniktech
Copy link
Contributor Author

Thanks for reopening! Library version is latest, I tried this out on the main branch at 85c98bb

@vanniktech
Copy link
Contributor Author

vanniktech commented Sep 26, 2022

This will NOT be closed by #440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants