Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - ActionMode is truncate. Please don't used non released dependencies #85

Closed
cmoijulien opened this issue Mar 12, 2021 · 4 comments · Fixed by #92
Closed

[BUG] - ActionMode is truncate. Please don't used non released dependencies #85

cmoijulien opened this issue Mar 12, 2021 · 4 comments · Fixed by #92

Comments

@cmoijulien
Copy link

cmoijulien commented Mar 12, 2021

  • Lib Version 2.2.1

Describe the bug

My action mode is truncate. This is due to a bug in the dependency of appcompat.
Please don't used non released dependencies to solve this issue.

Current lib dependencies version :

androidXAppCompatVersion = '1.3.0-beta01'

My workaround :

 implementation ('com.github.CanHub:Android-Image-Cropper:2.2.1'){
        exclude group: 'androidx.appcompat'
}

Screenshots
Screenshot_20210312_101507

Smartphone (please complete the following information):

  • Device: Honor 10
  • OS: Android 10 API 29
@Canato
Copy link
Member

Canato commented Mar 12, 2021

Sorry for the issue @cmoijulien we need to use this because of the new permissions Google/Android released, where we have different behaviours for OS under 9, OS 10 and OS 11.

Is on my plans to remove the permissions request from the library, passing to the user of the lib, but is a future work to be done!

Thanks for finding the problem and posting a workaround until we get there

@Canato
Copy link
Member

Canato commented Mar 12, 2021

Could you just double confirm if material version is a issue here? cause this should not be in the library gradle. Only the appcompat version

@cmoijulien
Copy link
Author

Could you just double confirm if material version is a issue here? cause this should not be in the library gradle. Only the appcompat version

No it's only appcompat version. I updated the report

@Canato Canato pinned this issue Mar 12, 2021
@Canato
Copy link
Member

Canato commented Mar 19, 2021

@cmoijulien just release a new version 2.2.2 where the library is using appCompat last stable version.

Will close the ticket, but let me know if is not fixed.

@Canato Canato closed this as completed Mar 19, 2021
@Canato Canato linked a pull request Mar 19, 2021 that will close this issue
@Canato Canato unpinned this issue Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants