Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculated Field names containing SQL reserved words will cause parse error #504

Open
imAsterSun opened this issue Jul 11, 2024 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@imAsterSun
Copy link
Contributor

Describe the bug
If column names or calculated field names in mdl are SQL reserved words e.g. from, it is possible that the generated SQL query causes parse error if LLM fail to add quotes around them.

To Reproduce
Steps to reproduce the behavior:

  1. create a CF and name it with SQL reserved words ( for ex. create a CF named “ Select” in the orders table
  2. deploy the models
  3. ask a question “ show me the orders table details”
  4. you will see the error msg “ no relevant SQL”

Expected behavior
Should inform user if SQL reserved words are not allowed, or add quote around the reserved words to prevent the issue happening.

@imAsterSun imAsterSun added the bug Something isn't working label Jul 11, 2024
@Smartmind12
Copy link

Hey @wwwy3y3 i would like to work on this issue...can you assign it to me?

@fredalai
Copy link
Contributor

fredalai commented Oct 5, 2024

@Smartmind12 assigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

4 participants