Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.37.0 image preview works fine, but 1.38.0 and 1.39.0 is broken. MacOS; WezTerm; #885

Closed
i-api opened this issue Jun 4, 2024 · 4 comments · Fixed by #897
Closed

Version 1.37.0 image preview works fine, but 1.38.0 and 1.39.0 is broken. MacOS; WezTerm; #885

i-api opened this issue Jun 4, 2024 · 4 comments · Fixed by #897
Labels
bug Something isn't working

Comments

@i-api
Copy link

i-api commented Jun 4, 2024 •
edited
Loading

1.37

broot_version_1 37

1.39

broot_version_1 39
@i-api i-api added the bug Something isn't working label Jun 4, 2024
@Canop
Copy link
Owner

Canop commented Jul 4, 2024 •
edited
Loading

As in tradition, this is a weird libc problem.

This call to ioctl was optimized away in release mode, due to the argument not being flagged as mutable.

Canop added a commit that referenced this issue Jul 4, 2024
@Canop
fix brocken ioctl call in release mode
ac0ffb0 
Fix #885
@Canop Canop mentioned this issue Jul 4, 2024
Merged
@Canop
Copy link
Owner

Canop commented Jul 4, 2024 •
edited
Loading

@i-api Can you check PR #897 fixes the problem for you ?

(if you have problem compiling, you can come and chat at https://miaou.dystroy.org/3490)

Canop added a commit that referenced this issue Jul 5, 2024
@Canop
Issue 885 (#897)
26d6110 
* remove name and subpath from bline

* remove fnv dependency

* fix brocken ioctl call in release mode

Fix #885

* better fix of the ioctl call being removed in release
@Canop Canop closed this as completed in #897 Jul 5, 2024
@i-api
Copy link
Author

i-api commented Jul 8, 2024

Can confirm! It fixes it!

@i-api
Copy link
Author

i-api commented Jul 8, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 885 Canop/broot
2 participants
@Canop @i-api