Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extinction criteria in diffusion_flame_extinction.py #1064

Closed
d-e-t opened this issue Jun 19, 2021 · 0 comments · Fixed by #1066
Closed

Extinction criteria in diffusion_flame_extinction.py #1064

d-e-t opened this issue Jun 19, 2021 · 0 comments · Fixed by #1066

Comments

@d-e-t
Copy link
Contributor

d-e-t commented Jun 19, 2021

The extinction criteria in the current Cantera 2.5 version of diffusion_flame_extinction.py only works if temperature_limit_extinction is set equal to the higher gas inlet temperature. In the current version both the oxidizer inlet and extinction temperature are set to 500 K. The code would be improved if the extinction limit were defined based on the inlet temperatures, such as changing line 67 to:

temperature_limit_extinction = max(f.oxidizer_inlet.T, f.fuel_inlet.T)

Alternatively, temperature_limit_extinction could be set using a dT above the max inlet temperature, and then extinction checked for with np.max(f.T) < temperature_limit_extinction, as in the <= 2.4 version of the example. (Instead of the current np.isclose() in line 144)

The stopping criteria for the example was changed with commit f13bbb9c, and this issue is discussed in the User Group here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant